Skip to content

Conversation

@stephenmcgruer
Copy link
Contributor

Closes #4299

@stephenmcgruer
Copy link
Contributor Author

I dont think anything else needs updated, but I was surprised at how small this change was.

@stephenmcgruer stephenmcgruer changed the title Move mutable timelines to web-animations-2 [web-animations-1][web-animations-2] Move mutable timelines to web-animations-2 Sep 13, 2019
Copy link
Contributor

@birtles birtles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think section 4.4.1. Setting the timeline of an animation should be moved to level 2, right?

@stephenmcgruer stephenmcgruer self-assigned this Sep 16, 2019
@stephenmcgruer
Copy link
Contributor Author

I think section 4.4.1. Setting the timeline of an animation should be moved to level 2, right

@birtles

I'm undecided about this. It is still used in the Animation (effect, timeline) constructor. That said, the timeline can't change so the steps there are probably irrelevant (have not confirmed yet). I'll need to convince myself that setting the timeline of an animation can't change anything during the Animation constructor, will look at that today :)

(Can't get github to actually show me the comment in the file, I think because it must have been made outside of the diff range? Not sure; clicking 'View changes' on your comment shows me nothing at all...)

@birtles
Copy link
Contributor

birtles commented Sep 16, 2019

(Can't get github to actually show me the comment in the file, I think because it must have been made outside of the diff range? Not sure; clicking 'View changes' on your comment shows me nothing at all...)

I think I probably made it as a review comment as opposed to an inline comment.

I'm undecided about this. It is still used in the Animation (effect, timeline) constructor. That said, the timeline can't change so the steps there are probably irrelevant (have not confirmed yet). I'll need to convince myself that setting the timeline of an animation can't change anything during the Animation constructor, will look at that today :)

I was just going off where bikeshed said that procedure was linked-to from. I didn't actually check the constructor itself so if it is used there, then we should probably leave it in level 1.

@stephenmcgruer
Copy link
Contributor Author

Ack. I switched to a partial interface for Animation, I think otherwise this is good to go.

@birtles
Copy link
Contributor

birtles commented Sep 16, 2019

Thanks. I suspect we can simplify the set the timeline procedure if it is only used by the Animation constructor but perhaps we can do that later.

@birtles birtles merged commit ce63fd2 into w3c:master Sep 16, 2019
@stephenmcgruer stephenmcgruer deleted the defer-mutable-timelines branch September 17, 2019 13:04
@stephenmcgruer
Copy link
Contributor Author

Hrm, seems like neither https://drafts.csswg.org/web-animations-2/ nor the level 1 version have been updated automatically after this merge. Do we know what process usually generates them and how to check on it? @birtles @graouts

@birtles
Copy link
Contributor

birtles commented Sep 18, 2019

Sometimes the spec generation process gets blocked. I normally ping @tabatkins when that happens.

@birtles
Copy link
Contributor

birtles commented Sep 18, 2019

It appears to have run now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[web-animations-1] Propose moving mutable timelines to web-animations-2

2 participants