-
Notifications
You must be signed in to change notification settings - Fork 757
[web-animations-1][web-animations-2] Move mutable timelines to web-animations-2 #4304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I dont think anything else needs updated, but I was surprised at how small this change was. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think section 4.4.1. Setting the timeline of an animation should be moved to level 2, right?
I'm undecided about this. It is still used in the (Can't get github to actually show me the comment in the file, I think because it must have been made outside of the diff range? Not sure; clicking 'View changes' on your comment shows me nothing at all...) |
I think I probably made it as a review comment as opposed to an inline comment.
I was just going off where bikeshed said that procedure was linked-to from. I didn't actually check the constructor itself so if it is used there, then we should probably leave it in level 1. |
|
Ack. I switched to a partial interface for |
|
Thanks. I suspect we can simplify the set the timeline procedure if it is only used by the |
|
Hrm, seems like neither https://drafts.csswg.org/web-animations-2/ nor the level 1 version have been updated automatically after this merge. Do we know what process usually generates them and how to check on it? @birtles @graouts |
|
Sometimes the spec generation process gets blocked. I normally ping @tabatkins when that happens. |
|
It appears to have run now. |
Closes #4299