Skip to content

[web-animations-1][web-animations-2] Move mutable timelines to web-animations-2 #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2019
Merged

[web-animations-1][web-animations-2] Move mutable timelines to web-animations-2 #4304

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fd0299
Move mutable timelines to web-animations-2
stephenmcgruer Sep 13, 2019
d2bff13
move to partial interface
stephenmcgruer Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Move mutable timelines to web-animations-2
  • Loading branch information
@stephenmcgruer
stephenmcgruer committed Sep 13, 2019
commit 1fd029958749dea79e889418e5e60274e738c7e8
4 changes: 1 addition & 3 deletions web-animations-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3996,7 +3996,7 @@ API by the {{Animation}} interface.
interface Animation : EventTarget {
attribute DOMString id;
attribute AnimationEffect? effect;
attribute AnimationTimeline? timeline;
readonly attribute AnimationTimeline? timeline;
attribute double? startTime;
attribute double? currentTime;
attribute double playbackRate;
Expand Down Expand Up @@ -4066,8 +4066,6 @@ interface Animation : EventTarget {
the procedure to <a>set the target effect of an animation</a>.
: <dfn attribute for=Animation>timeline</dfn>
:: The <a>timeline</a> associated with this animation.
Setting this attribute updates the object's <a>timeline</a> using
the procedure to <a>set the timeline of an animation</a>.
: <dfn attribute for=Animation>startTime</dfn>
:: Returns the [=start time=] of this animation.
Setting this attribute updates the [=start time=] using
Expand Down
21 changes: 21 additions & 0 deletions web-animations-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ urlPrefix: https://drafts.csswg.org/web-animations-1/; type: dfn; spec: web-anim
text: playback direction
text: pause an animation
text: ready
text: set the timeline of an animation
text: simple iteration progress
text: target effect
text: target element
Expand Down Expand Up @@ -1440,6 +1441,26 @@ partial interface AnimationTimeline {

</div>

<h3 id="the-animation-interface">The <code>Animation</code> interface</h3>

The <a>Animation</a> interface is amended to make the <var>timeline</var> member mutable:

<pre class='idl'>
[Exposed=Window,
Constructor(optional AnimationEffect? effect = null,
optional AnimationTimeline? timeline)]
interface Animation : EventTarget {
attribute AnimationTimeline? timeline;
};
</pre>

<div class='attributes'>

: <dfn attribute for=Animation>timeline</dfn>
:: The <a>timeline</a> associated with this animation.
Setting this attribute updates the object's <a>timeline</a> using
the procedure to <a>set the timeline of an animation</a>.

<h3 id="the-animationeffectreadonly-interface">The <code>AnimationEffectReadOnly</code> interface</h3>


Expand Down