[scroll-animations] Update scroll timeline css syntax and properties (#4338, #4336) #4751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I had a quick glance at this today and it looks good so far. I wonder if I'm the best reviewer though? |
Contributor
Author
|
@birtles thanks for the high level check! I agree that we should use your limited time more effectively so I rather you stay focused on #2066 and potential PR for that. As I suggested offline we should share the review load for this spec across all editors and I am working to ensure we have enough active editors on this specification to help make forward progress. @graouts or @theres-waldo would either of you be able to review this for scroll-linked animations? |
ogerchikov
reviewed
Feb 25, 2020
ogerchikov
reviewed
Feb 25, 2020
ogerchikov
reviewed
Feb 25, 2020
ogerchikov
reviewed
Feb 25, 2020
Introduce @timeline at-rule Allow animation-name property to be used to select timeline Update examples to use new syntax Use shorted names for properties: startScrollOffset => start endScrollOffset => end scrollSource => source Minor changes to avoid bikeshed WARNING: - disambiguate reference to rAF - Reference layout cycle
cb212ee to
c3c59bb
Compare
JTensai
pushed a commit
to JTensai/csswg-drafts
that referenced
this pull request
May 13, 2020
…3c#4338, w3c#4336) (w3c#4751) ## Introduce @timeline at-rule Allow animation-name property to be used to select timeline Update examples to use new syntax ## Use shorted names for properties: startScrollOffset => start endScrollOffset => end scrollSource => source ## Minor changes to avoid bikeshed WARNING: - disambiguate reference to rAF - Reference layout cycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make improvements to CSS syntax based on previous CSSWG discussions.
New at-rule
This addresses issue #4338 .
Introduce @timeline at-rule. The rule is used to specify parameters for scroll timeline (but can later
be used for regular timelines as well).
The animation-timeline property would select the appropriate at-rule based on its name.
I have also added language to allow existing
animation-nameproperty to be used for this as well. This will improve ergonomics IMO. But I can drop this part and have it as a separate PR if there is concern.Shorter names for Scroll Timeline properties
This addresses #4336
Use shorter names for properties:
Other changes
Minor changes to avoid bikeshed WARNING: