[scroll-animations] let source be explicitly nullable (#5202, #5211) #5263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Fix IDL to make source nullable. - In CSS source will accept 'auto' and 'none' with none mapping to null. - In JS, we now map missing 'source' to document scrolling element (i.e., auto behavior) and explicitly null 'source' to null. - Correctly check null source when calculating offsets. Other minor cleanups.
birtles
approved these changes
Jun 26, 2020
|
Spec is fixed. Have filed a bug to fix Chromium implementation. |
andruud
pushed a commit
to andruud/csswg-drafts
that referenced
this pull request
Aug 21, 2020
…source Follow-up to w3c#5263, which specifies that a "missing" source shall result in using the Document's scrollingElement, but if we give source a default value of null, it can never be missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #5202 and #5211
Changes:
mapping to null.
(i.e., auto behavior) and explicitly null 'source' to null.
Other minor cleanups.