[scroll-animations-1] Remove default vaule for ScrollTimelineOptions.source #5460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source Follow-up to w3c#5263, which specifies that a "missing" source shall result in using the Document's scrollingElement, but if we give source a default value of null, it can never be missing.
Member
Author
|
cc @flackr |
Member
Author
|
No response from @flackr, can you have a look at this @ogerchikov? |
flackr
approved these changes
Oct 23, 2020
Contributor
flackr
left a comment
There was a problem hiding this comment.
LGTM, sorry for the delay on this
Collaborator
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5263, which specifies that a "missing" source shall
result in using the Document's scrollingElement, but if we give
source a default value of null, it can never be missing.