[css-text][css-text-decor][css-writing-modes][css-color][css-fonts][css-color-adjust] Be explicit about which properties apply to text. #5303#5761
Conversation
|
Not sure I caught them all, but I tried. :) |
svgeesus
left a comment
svgeesus
left a comment
There was a problem hiding this comment.
Yes, this seems correct to me.
|
Are you trying to cover all the specs here? At quick glance, things like |
|
@Loirooriol I think |
Loirooriol
left a comment
Loirooriol
left a comment
There was a problem hiding this comment.
Looks good, but I think some surrounding text may need to be tweaked.
| Value: none | all | [ digits <integer>? ] | ||
| Initial: none | ||
| Applies to: non-replaced inline elements | ||
| Applies to: [=inline boxes=] and text |
There was a problem hiding this comment.
text-combine-upright: all is defined with
Attempt to typeset horizontally all consecutive typographic character units within the box
So it's not clear what happens for text. Maybe "within the box or text run"?
There was a problem hiding this comment.
Hmm... this is an interesting point. I was originally thinking that applying this to text would only make sense for the digits value (which is why I didn't edit css-writing-modes-3) and not the all value. Can make that clearer, or can say that it only applies to boxes, or can apply it to text runs as you say. I'm not sure there's a real use case for the last one, so I think we should go with whatever makes the most sense to implementers. CC @litherum @kojiishi @jfkthame What do you think? The situation is span { display: contents; text-combine-upright: <something>; }: should this have an effect or have no effect? If so should it work for both all and digits or only for one of them? It doesn't seem particularly useful, so the question is what's easiest to implement. :)
There was a problem hiding this comment.
<div style="writing-mode: vertical-lr">
<span style="display: contents; text-combine-upright: all">foo</span>has effect in Firefox and Chromium. They don't support digits.
There was a problem hiding this comment.
Seems WebKit has -webkit-text-combine: horizontal instead of text-combine-upright: all, and it has no effect with display: contents. But it's a non-inherited property, so it's expected that the text doesn't inherit it, I guess.
…ss-color-adjust] Be explicit about which properties apply to text. w3c#5303
fantasai
force-pushed
the
applies-to-text
branch
from
d3e3f44 to
1339a16
Compare
|
Should <span style="display: contents; writing-mode: vertical-lr">foo</span>In Firefox it works just like without |
|
@Loirooriol I think not, it's supposed to create an inline block and I think that needs a box!! |
|
Yes, but we could say that text with an orthogonal writing mode is placed inside an anonymous inline-block with the writing mode of the text. |
5 participants
No description provided.