[css-text][css-text-decor][css-writing-modes][css-color][css-fonts][css-color-adjust] Be explicit about which properties apply to text. #5303

[fantasai]

No description provided.

[fantasai]

Not sure I caught them all, but I tried. :)

[svgeesus]

Yes, this seems correct to me.

[Loirooriol]

Are you trying to cover all the specs here? At quick glance, things like cursor from css-ui should probably be added too.

[fantasai]

@Loirooriol I think cursor is a bit tricky. We don't define the geometric bounds of text, except insofar as the glyph outline is defined, so if we were to say it applies to text, we wouldn't be able to say where it applies.

[Loirooriol]

Looks good, but I think some surrounding text may need to be tweaked.

[Loirooriol]

text-combine-upright: all is defined with

Attempt to typeset horizontally all consecutive typographic character units within the box

So it's not clear what happens for text. Maybe "within the box or text run"?

[fantasai]

Hmm... this is an interesting point. I was originally thinking that applying this to text would only make sense for the digits value (which is why I didn't edit css-writing-modes-3) and not the all value. Can make that clearer, or can say that it only applies to boxes, or can apply it to text runs as you say. I'm not sure there's a real use case for the last one, so I think we should go with whatever makes the most sense to implementers. CC @litherum @kojiishi @jfkthame What do you think? The situation is span { display: contents; text-combine-upright: <something>; }: should this have an effect or have no effect? If so should it work for both all and digits or only for one of them? It doesn't seem particularly useful, so the question is what's easiest to implement. :)

[Loirooriol]

<div style="writing-mode: vertical-lr">
  <span style="display: contents; text-combine-upright: all">foo</span>

has effect in Firefox and Chromium. They don't support digits.

[fantasai]

OK, made the fixes in 0b31fa9

[Loirooriol]

Seems WebKit has -webkit-text-combine: horizontal instead of text-combine-upright: all, and it has no effect with display: contents. But it's a non-inherited property, so it's expected that the text doesn't inherit it, I guess.

[Loirooriol]

Should writing-mode apply to text?

<span style="display: contents; writing-mode: vertical-lr">foo</span>

In Firefox it works just like without display: contents. In Chromium, the letters are upright, but each one in a different line, and the lines are shifted to the right, weird.

[fantasai]

@Loirooriol I think not, it's supposed to create an inline block and I think that needs a box!!

[Loirooriol]

Yes, but we could say that text with an orthogonal writing mode is placed inside an anonymous inline-block with the writing mode of the text.