[scroll-animations-1] Progress percentages must be between 0% and 100% #8553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantasai
requested changes
Mar 10, 2023
There was a problem hiding this comment.
Since we're considering allowing out-of-range percentages in #8552 I don't think we should be merging this PR.
If you only add [0,100] to the first instance of <<percentage>>, though, that would be acceptable because raw percentages must be between 0%-100%.
|
Yeah, I was a bit too hasty with this PR. Good to read out-of-range percentages are allowed after all :) |
fantasai
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8552.