[css-backgrounds-4] Defined box-shadow-* as coordinating list property group
#8613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loirooriol
reviewed
Mar 19, 2023
css-backgrounds-4/Overview.bs
Outdated
Comment on lines
776
to
780
| Animatable: by computed value, | ||
| appending blank shadows (''transparent 0 0 0 0'') | ||
| with a corresponding ''box-shadow-position/inset'' keyword as needed | ||
| to match the longer list | ||
| if the shorter list is otherwise compatible with the longer one |
There was a problem hiding this comment.
I guess that this should actually be split and put the relevant part to the corresponding longhand.
So box-shadow-offset will append 0 0, box-shadow-color will append transparent, etc.
Also, to preserve the old behavior, I guess that none should be treated as 0 0 when interpolated with a non-none value?
cdoublev
reviewed
Mar 21, 2023
css-backgrounds-4/Overview.bs
Outdated
| Animatable: by computed value | ||
| Computed value: list, each item either 'none' or a pair of offsets | ||
| (horizontal and vertical) from the element‘s box | ||
| Animatable: by computed value, |
There was a problem hiding this comment.
Can you please use Animation type, as required in Web Animations? 🙏 Otherwise w3c/reffy would extract rules with fields mixing animationType/animatable.
There was a problem hiding this comment.
Ah sorry! #8605 (comment)
fc898da to
48fe682
Compare
The section "Layering, Layout and Other Details" is copied over from Level 3 and extended to define the shadows as coordinating list property group.
48fe682 to
94ad9a7
Compare
|
Closing this PR in favor of #9186. The rest of the patch here should already be in the spec. now. Sebastian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied over the section from Level 3 about "Layering, Layout, and Other Details" of box shadows and defined the longhands as coordinating list property group with
box-shadow-offsetbeing the coordinating list base property.I've also move the "Animatable" definition to
box-shadow-offset. Though I have to admit, I am not completely sure whether it fits there.Maybe there should be a new section "Animation of Drop Shadows" explaining this in more detail?
This patch is based on the changes of #8605 to avoid any merge conflicts. So the other one should be merged first.
This is meant to fix #8592.
Sebastian