[css-borders-4] Defined box-shadow-* as coordinating list property group
#9186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoublev
approved these changes
Aug 14, 2023
Loirooriol
reviewed
Aug 14, 2023
Contributor
Loirooriol
left a comment
There was a problem hiding this comment.
This is just importing from L3, so feel free to land as-is and fix problems later. But I think this should refer to fragments instead of boxes.
Also, reminder to fix the animation types to handle lists (#9096 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied over the section from Level 3 about "Layering, Layout, and Other Details" of box shadows and defined the longhands as coordinating list property group with
box-shadow-offsetbeing the coordinating list base property.This is meant to fix #8592 and supersedes #8613.
Sebastian