Skip to content

[css-view-transitions-1] Algorithms Section: various minor editorial fixes #8956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2023
Merged

[css-view-transitions-1] Algorithms Section: various minor editorial fixes #8956

merged 4 commits into from
Jun 13, 2023

Conversation

@fantasai
Copy link
Collaborator

@fantasai fantasai commented Jun 13, 2023 •
edited
Loading

It's probably easiest to review commit by commit. This PR does three things:

  • Renames “transition suppressing rendering” to “rendering suppression for view transitions” which is longer but more understandable and also more clearly a noun. Another option might be “transition rendering suppression”... I'm not entirely sure of the nuance we're going for, but “transition suppressing rendering” definitely feels awkward.
  • Renames “show view-transition root pseudo-element” to “show view transition tree”; because (afaict) fundamentally this is about displaying the entire tree, not just the root of it
  • Makes a bunch of minor fixes to prepositions and markup

This PR builds on top of #8954

@fantasai fantasai changed the title [css-view-transitions-1] Agorithms Section: various minor editorial fixes [css-view-transitions-1] Algorithms Section: various minor editorial fixes Jun 13, 2023
khushalsagar
khushalsagar approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@khushalsagar khushalsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit was on another PR which I already reviewed so skipped adding the same comments here.

css-view-transitions-1/Overview.bs

When this is true, [=this=]'s [=active view transition=]'s [=ViewTransition/transition root pseudo-element=] renders as a child of [=this=]'s [=document element=],
and [=this=]'s [=document element=] is its [=originating element=].
with [=this=]'s [=document element=] is its [=originating element=].
Copy link
Member

@khushalsagar khushalsagar Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with [=this=]'s [=document element=] is its [=originating element=].
with [=this=]'s [=document element=] as its [=originating element=].

Current sentence looks grammatically incorrect.

@fantasai fantasai merged commit 463e82c into w3c:main Jun 13, 2023
@fantasai fantasai deleted the vtalgo-editorial branch June 13, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khushalsagar khushalsagar khushalsagar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fantasai @khushalsagar