[web-animations-1] Restructure and Improve DFNs in Animation Effects section #8985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess a somewhat relevant question here is whether we want to rename “timing function” to “easing function” while we're at it. |
birtles
reviewed
Aug 17, 2023
9089166 to
3f89c42
Compare
fantasai
added a commit
to fantasai/csswg-drafts
that referenced
this pull request
Aug 18, 2023
birtles
reviewed
Aug 19, 2023
This makes it easier to understand what this object is and to contextualize all the definitions that follow.
This improves the flow of the story we're telling about what an animation effect is and how it works. (See next commit for tweaks on the text; this only moves it.)
* give local time a proper DFN * tweak Time Spaces to fit as an overview for more than just the iteration section * use proper dfn markup for the various terms defined in the Time Spaces overview
…vs Progress Calculations This restructuring sorts various subsections into: * properties of an animation effect -> filed as direct subsections of Animation Effect * transformation of the input time into output progress -> filed as direct subsections of Calculating Progress This way the first section builds up the model of what an Animation Effect *is*, and the second section defines the flow of time through various transformations into an output progress value. (See next commit for integration edits; this only moves text.)
…timing function * Integrate normative and non-normative text of “direction control” and give each playback direction value a proper definition. * DFN a term for the effect-wide easing function, and clarify its effect. * DFN “keyframe-specific timing function” for parallelism and easier referencing.
b33d125 to
7b3a173
Compare
birtles
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #8965 ... This refactors the Animation Effects section of the Web Animations model.
Have not yet worked through the progress calculation section (other than teasing out things which should go ahead of it), so haven't dealt with #8965 (comment), but it's almost 2am so submitting everything I've got for above it since it's a pretty coherent set of changes as-is. :)