[web-animations-1] Define 'start time' for animation effects #9219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was pretty opposed to introducing two kinds of start times but I notice we already have a concept of animation effect end time so I guess this makes sense. |
birtles
reviewed
Aug 23, 2023
|
|
||
| 1. If there is a [=pending pause task=] | ||
| and [=start time=] is [=unresolved|resolved=], | ||
| and [=animation/ time=] is [=unresolved|resolved=], |
Comment on lines
+2644
to
+2645
| The <dfn for="animation effect">start time</dfn> of an [=animation effect=] | ||
| is the [=animation/start time=] of its [=associated animation=]. |
There was a problem hiding this comment.
Should we define this as zero local time and say that this happens to correspond to the start time of the associated animation effect? That's how we describe the endTime API member.
I noticed we already have a definition of animation effect start time in Web Animations level 2: https://drafts.csswg.org/web-animations-2/#animation-effect-start-time
I think what we have here is compatible with that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8985 (comment)
In Level 2, we can change just the definition of "start time" to handle sequencing, and those adjustments will flow through the rest of the definitions appropriately.