[css-backgrounds-4] Added background-layer property
#9084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8687140 to
d8267ba
Compare
fantasai
requested changes
Sep 13, 2023
93f83a4 to
2e624d2
Compare
|
@fantasai I've incorporated your comments. Could you please give it another review? Sebastian |
…r now and clarified how it works The name of the property is still under discussion, so to avoid implementations, it got renamed to `background-tbd` for now. Also, the issue for the name discussion was added. Furthermore, the description of the property got clarified a bit.
2e624d2 to
2fdf9b0
Compare
|
As I've incorporated @fantasai's remarks quite a while back and didn't get any more feedback, I go ahead and merge this. Sebastian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
background-layerproperty as a shorthand for everything related to background layers excludingbackground-color.It follows the resolution of #8726 (comment).
Note that I went with
background-layerfor now. The name might still change, which is discussed in #9083.Fixes #8726
Sebastian