Skip to content

[css-borders-4] Fixed and added definitions for box-shadow-offset: none #9096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 2, 2023
Merged

[css-borders-4] Fixed and added definitions for box-shadow-offset: none #9096

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d412088
[css-borders-4] Fixed and added definitions for box-shadow-offset: none
SebastianZ Jul 19, 2023
b0da2bd
[css-borders-4] Fixed 'box-shadow' shorthand definition
SebastianZ Jul 19, 2023
668a239
[css-borders-4] Moved animation type to box-shadow-offset and fixed c…
SebastianZ Jul 26, 2023
f90d2a2
[css-borders-4] Fixed animation type of `box-shadow-offset` and inter…
SebastianZ Jul 27, 2023
532f74c
[css-borders-4] Clarified the `none` value of `box-shadow-offset`
SebastianZ Jul 27, 2023
8178637
[css-borders-4] Improved phrasing of `box-shadow-offset: none` and ex…
SebastianZ Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions css-borders-4/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,16 +617,25 @@ Initial: none
Applies to: all elements
Inherited: no
Percentages: N/A
Computed value: either 'none' or a list,
each item a pair of offsets (horizontal and vertical) from the element‘s box
Animation type: by computed value
Computed value: list, each item either 'none' or a pair of offsets
(horizontal and vertical) from the element‘s box
Animation type: by computed value,
treating ''box-shadow-offset/none'' as ''0 0''
when interpolated with non-'none' values.
Copy link
Contributor

@Loirooriol Loirooriol Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to say that if the lists have different lengths, none values are added to the short list until the have the same length.

Something analogous for the other longhands. Possibly consider a new animation type like "defaultable list" or something, since there already is a "repeatable list".

Copy link
Contributor Author

@SebastianZ SebastianZ Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to add the everything related to the coordinating list property group in #8613.

I was also thinking about the animation type, as "repeatable list" doesn't fit here. @fantasai Any ideas?

</pre>

<p>The 'box-shadow-offset' property defines one or more drop shadow offsets.
The property accepts a comma-separated list of horizontal and vertical offset pairs,
The property accepts a comma-separated list.
Each item in that list can either be the ''box-shadow-offset/none'' value,
which indicates no shadow, or a pair of horizontal and vertical offsets,
where both values are described as <<length>> values.

<dl>
<dt><dfn id="shadow-offset-none">none</dfn>
<dd>
The shadow will not be rendered.
The values of other box shadow properties corresponding to this shadow have no effect.

<dt><dfn id="shadow-offset-x">1st <<length>></dfn>
<dd>
Specifies the <dfn>horizontal offset</dfn> of the shadow.
Expand Down Expand Up @@ -741,25 +750,21 @@ Initial: none
Applies to: all elements
Inherited: no
Percentages: N/A
Computed value: either the keyword ''box-shadow-offset/none'' or
a list, each item consisting of four absolute lengths
plus a computed color and optionally also a ''box-shadow-position/inset'' keyword
Animation type: by computed value,
treating ''box-shadow-offset/none'' as a zero-item list
and appending blank shadows (''transparent 0 0 0 0'')
with a corresponding ''box-shadow-position/inset'' keyword as needed
to match the longer list
if the shorter list is otherwise compatible with the longer one
Computed value: see individual properties
Animation type: see individual properties
</pre>

<p>The 'box-shadow' property attaches one or more drop-shadows to the box.
The property accepts either the ''box-shadow-offset/none'' value, which indicates no shadows,
or a comma-separated list of shadows, ordered front to back.
The property accepts a comma-separated list of shadows,
ordered front to back.

<p>Each shadow is given as a <<spread-shadow>>,
outlining the 'box-shadow-offset', and optional values for the 'box-shadow-blur',
'box-shadow-spread', 'box-shadow-color', and 'box-shadow-position'.
Omitted lengths are 0; omitted colors default to the ''currentcolor'' value.
Omitted lengths are '0';
omitted colors default to ''transparent'' when the specified offset is ''box-shadow-offset/none''
and to ''currentcolor'' otherwise.

<pre class=prod>
<dfn><<spread-shadow>></dfn> = <<'box-shadow-color'>>? &amp;&amp; [ <<'box-shadow-offset'>> [ <<'box-shadow-blur'>> <<'box-shadow-spread'>>? ]? ] &amp;&amp; <<'box-shadow-position'>>?</pre>

Expand Down