Skip to content

Consistent format for syntax errors. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2016

Conversation

andreypopp
Copy link
Contributor

I used babel-code-frame package formatting syntax errors code frames. That makes it consistent with Babel output which is I think very important as it makes it less cognitive efforts to recognize and process the error.

You can also see that there's no duplicated filename in error message as webpack already print module name.

Before:

screenshot 2016-08-15 19 47 37

After:

screenshot 2016-08-15 19 46 07

See also:

@codecov-io
Copy link

codecov-io commented Aug 15, 2016

Current coverage is 98.34% (diff: 91.66%)

Merging #319 into master will increase coverage by 0.13%

@@             master       #319   diff @@
==========================================
  Files             9          9          
  Lines           280        303    +23   
  Methods          39         41     +2   
  Messages          0          0          
  Branches         60         66     +6   
==========================================
+ Hits            275        298    +23   
  Misses            5          5          
  Partials          0          0          

Powered by Codecov. Last update 9d2941b...9343ebb

@sokra
Copy link
Member

sokra commented Aug 16, 2016

awsome 👍. A test would be great 😄

@andreypopp
Copy link
Contributor Author

@sokra done!

@sokra
Copy link
Member

sokra commented Aug 16, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants