Consistent format for CSS syntax errors

[andreypopp]

I used babel-code-frame package formatting syntax errors code frames. That makes it consistent with Babel output which is I think very important as it makes it less cognitive efforts to recognize and process the error. Also code frames are a little bit fancies now (shows the line numebrs) so probably PostCSS itself should adopt this style.

You can also see that there's no duplicated filename in error message as webpack already print module name.

Before:

After:

[ai]

Awesome. It will be very useful.

But maybe we should change it in PostCSS core? Could you send PR there?

[andreypopp]

Hey @ai, I'd be glad to make a PR to PostCSS core but this PR is specific to webpack as it doesn't render filename of the file errors happened into (something you don't want to miss in general case).

I'd suggest taking this PR here and then I'd make PostCSS reuse babel-code-frame for source code formatting.

[ai]

Yeap:

1. We could add line numbers to PostCSS core.
2. Then we could fix file path in error in loader.

Looks good?

[andreypopp]

Thanks @ai!
On Wed, 17 Aug 2016 at 18:07, Andrey Sitnik notifications@github.com
wrote:

Merged #87 #87.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#87 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAB3glJy-e-W1m1UYRrFaeKAUsR-UyC7ks5qgyPIgaJpZM4JkjIx
.