feat: Enable esModule by default
#486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 5 5
Lines 426 426
Branches 94 94
=======================================
Hits 377 377
Misses 47 47
Partials 2 2
Continue to review full report at Codecov.
|
Since it can allow webpack's module concatenation and tree shaking to work more effectively. webpack 4 supports ES Modules syntax out of the box (and doesn't output ESM itself), so this is not a breaking change. Fixes #485.
|
@evilebottnawi Hi :-) I don't suppose you have a moment to review this? |
|
Afaik this also has a functional difference when consuming modules with |
|
Done #602, release will be today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Since it can allow webpack's module concatenation and tree shaking to work more effectively, and having
esModuledisabled by default means more boilerplate and having to know that the feature exists.Breaking Changes
None, since webpack 4 supports ES Modules syntax out of the box (and doesn't output ESM itself), and this plugin only supports webpack 4 and newer.
Additional Info
Fixes #485.