Skip to content

Refactor: remove hmr option in favor Hot Module Replacement #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 9, 2020

Conversation

cap-Bernardito
Copy link
Member

@cap-Bernardito cap-Bernardito commented Oct 7, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

  • Removed hmr option in favor Hot Module Replacement
  • Removed moduleFilename option in favor filename option
  • Removed reloadAll option
  • Enabled esModule option by default
  • chunkFilename option can be a function for webpack@5
  • Updated dependencies

Breaking Changes

Yes, see Motivation section.

  • minimum supported Node.js version is 10.13.0

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #602 into master will increase coverage by 0.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   88.00%   88.51%   +0.51%     
==========================================
  Files          10       20      +10     
  Lines         600     1202     +602     
  Branches      155      309     +154     
==========================================
+ Hits          528     1064     +536     
- Misses         69      132      +63     
- Partials        3        6       +3     
Impacted Files Coverage Δ
src/hmr/hotModuleReplacement.js 90.74% <100.00%> (+2.77%) ⬆️
src/index.js 91.11% <100.00%> (+0.03%) ⬆️
src/loader.js 90.74% <100.00%> (ø)
...lugin/mini-css-extract-plugin/src/CssDependency.js 100.00% <0.00%> (ø)
...xtract-plugin/mini-css-extract-plugin/src/index.js 91.11% <0.00%> (ø)
...in/mini-css-extract-plugin/src/CssModuleFactory.js 100.00% <0.00%> (ø)
...tract-plugin/mini-css-extract-plugin/src/loader.js 90.74% <0.00%> (ø)
...css-extract-plugin/src/hmr/hotModuleReplacement.js 90.74% <0.00%> (ø)
...ni-css-extract-plugin/src/CssDependencyTemplate.js 100.00% <0.00%> (ø)
...ct-plugin/mini-css-extract-plugin/src/CssModule.js 62.68% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b935f26...10bd107. Read the comment docs.

@cap-Bernardito cap-Bernardito force-pushed the refactor-remove-hmr-option branch from f6e6c56 to e175c3d Compare October 8, 2020 10:43
@cap-Bernardito cap-Bernardito force-pushed the refactor-remove-hmr-option branch from 0bb0311 to ef5688a Compare October 8, 2020 11:03
@alexander-akait alexander-akait mentioned this pull request Oct 9, 2020
6 tasks
@fayeah
Copy link

fayeah commented May 6, 2022

hi what's this version of 'remove moduleFilename'? I am doing some version migration which throw this error because of the moduleFilename option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants