Skip to content

Conversation

@tiendq
Copy link
Contributor

@tiendq tiendq commented May 23, 2018

This PR contains a:

Motivation / Use-Case

Update advanced example.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How mode related to mini-css-extract-plugin?

@tiendq
Copy link
Contributor Author

tiendq commented May 23, 2018

@evilebottnawi mode makes sense in the advanced example of this plugin (check README file), the example doesn't work if you use mode argument with webpack, what @EddyVinck used in #154. It works if NODE_ENV is used.

@michael-ciniawsky
Copy link
Member

This is unrelated to mini-css-extract-plugin in particular and therefore unnecessarily 'bloats' the plugin README. The fact that webpack's mode doesn't rely on process.env.NODE_ENV needs to be extrapolated/documented elsewhere e.g in webpack/webpack.js.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants