Skip to content

docs: update advanced example #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tiendq wants to merge 1 commit into from
Closed

docs: update advanced example #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,11 @@ This plugin should be used only on `production` builds without `style-loader` in

Here is an example to have both HMR in `development` and your styles extracted in a file for `production` builds.

(Loaders options left out for clarity, adapt accordingly to your needs.)
Please note that there is an open issue with Webpack's `mode` configuration ([#7074](https://github.com/webpack/webpack/issues/7074)), you need to set NODE_ENV in the command line instead of relying on the `mode` argument of `webpack-cli`.

e.g. `NODE_ENV=production webpack` and not `webpack --mode=production`

(Loaders options left out for clarity, adapt accordingly to your needs.)

**webpack.config.js**

Expand All @@ -83,6 +86,7 @@ const MiniCssExtractPlugin = require("mini-css-extract-plugin");
const devMode = process.env.NODE_ENV !== 'production'

module.exports = {
mode: process.env.NODE_ENV,
plugins: [
new MiniCssExtractPlugin({
// Options similar to the same options in webpackOptions.output
Expand Down