refactor: webpack@4 dropped #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
- Coverage 89.31% 88.40% -0.92%
==========================================
Files 6 6
Lines 805 664 -141
Branches 247 161 -86
==========================================
- Hits 719 587 -132
+ Misses 83 76 -7
+ Partials 3 1 -2
Continue to review full report at Codecov.
|
BREAKING CHANGE: trailing slash at is no longer automatically added for the `publicPath` option, you need added them in configuration, i.e. `publicPath: "/public-path"` should be `publicPath: "/public-path/"`
alexander-akait
pushed a commit
that referenced
this pull request
Jun 25, 2021
* refactor: tests for webpack@4 dropped * refactor: tests * refactor: webpack@4 dropped * fix: publicPath auto (#771) BREAKING CHANGE: trailing slash at is no longer automatically added for the `publicPath` option, you need added them in configuration, i.e. `publicPath: "/public-path"` should be `publicPath: "/public-path/"`
alexander-akait
pushed a commit
that referenced
this pull request
Jun 25, 2021
* refactor: tests for webpack@4 dropped * refactor: tests * refactor: webpack@4 dropped * fix: publicPath auto (#771) BREAKING CHANGE: trailing slash at is no longer automatically added for the `publicPath` option, you need added them in configuration, i.e. `publicPath: "/public-path"` should be `publicPath: "/public-path/"`
alexander-akait
pushed a commit
that referenced
this pull request
Jun 28, 2021
* refactor: tests for webpack@4 dropped * refactor: tests * refactor: webpack@4 dropped * fix: publicPath auto (#771) BREAKING CHANGE: trailing slash at is no longer automatically added for the `publicPath` option, you need added them in configuration, i.e. `publicPath: "/public-path"` should be `publicPath: "/public-path/"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
webpack@4 dropped
Breaking Changes
Yes
Additional Info
No