fix: publicPath auto #771
Merged
fix: publicPath auto #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## drop-webpack4 #771 +/- ##
=================================================
+ Coverage 88.40% 88.47% +0.06%
=================================================
Files 6 6
Lines 664 668 +4
Branches 169 169
=================================================
+ Hits 587 591 +4
Misses 76 76
Partials 1 1
Continue to review full report at Codecov.
|
1b49f48 to
31f7378
Compare
alexander-akait
approved these changes
Jun 25, 2021
alexander-akait
pushed a commit
that referenced
this pull request
Jun 25, 2021
* refactor: tests for webpack@4 dropped * refactor: tests * refactor: webpack@4 dropped * fix: publicPath auto (#771) BREAKING CHANGE: trailing slash at is no longer automatically added for the `publicPath` option, you need added them in configuration, i.e. `publicPath: "/public-path"` should be `publicPath: "/public-path/"`
alexander-akait
pushed a commit
that referenced
this pull request
Jun 25, 2021
* refactor: tests for webpack@4 dropped * refactor: tests * refactor: webpack@4 dropped * fix: publicPath auto (#771) BREAKING CHANGE: trailing slash at is no longer automatically added for the `publicPath` option, you need added them in configuration, i.e. `publicPath: "/public-path"` should be `publicPath: "/public-path/"`
alexander-akait
pushed a commit
that referenced
this pull request
Jun 25, 2021
* refactor: tests for webpack@4 dropped * refactor: tests * refactor: webpack@4 dropped * fix: publicPath auto (#771) BREAKING CHANGE: trailing slash at is no longer automatically added for the `publicPath` option, you need added them in configuration, i.e. `publicPath: "/public-path"` should be `publicPath: "/public-path/"`
alexander-akait
pushed a commit
that referenced
this pull request
Jun 28, 2021
* refactor: tests for webpack@4 dropped * refactor: tests * refactor: webpack@4 dropped * fix: publicPath auto (#771) BREAKING CHANGE: trailing slash at is no longer automatically added for the `publicPath` option, you need added them in configuration, i.e. `publicPath: "/public-path"` should be `publicPath: "/public-path/"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fixes #729
Fixes #691
autosubstitution trailing slash for publicPath dropped
Breaking Changes
autosubstitution trailing slash for publicPath dropped
Additional Info
No