Fixes #60, Supports Markdown Files #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zignd
requested changes
Jun 9, 2017
src/extension.ts
Outdated
| @@ -117,6 +117,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<void> | |||
| const php = provideCompletionItemsGenerator('php', htmlRegex); | |||
| const vue = provideCompletionItemsGenerator('vue', htmlRegex); | |||
| const twig = provideCompletionItemsGenerator('twig', htmlRegex); | |||
| const md = provideCompletionItemsGenerator('md', htmlRegex); | |||
There was a problem hiding this comment.
Replace md with markdown. It's the correct language id and without this properly set the extension will not work for Markdown.
There was a problem hiding this comment.
Ah, I thought it was simply referring to the file extension. Let me know if that's enough.
zignd
approved these changes
Jun 9, 2017
|
All good now, I'll release a new version in a moment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the changes necessary to support PHP files and the like, this simple PR extends support to Markdown files. This is extremely useful for Jekyll sites which mix HTMl inside markdown, along with other Liquid or similarly built frameworks.
Should be noted, similar functionality exists in rival extension HTML CSS Support, so it makes sense to add such support here.