Skip to content

Fixes #60, Supports Markdown Files #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zignd merged 5 commits into from
Jun 9, 2017
Merged

Fixes #60, Supports Markdown Files #61

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a36dd8
Fixes #60, Adds support for md files
cvharris Jun 9, 2017
b9b107d
Updates README
cvharris Jun 9, 2017
d60700c
Bumps version
cvharris Jun 9, 2017
5b7901a
Updates CHANGELOG
cvharris Jun 9, 2017
b54423b
Fixes markdown language id
cvharris Jun 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixes #60, Adds support for md files
  • Loading branch information
@cvharris
cvharris authored Jun 9, 2017
commit 3a36dd8b02810d29b804ed75b6dee89eef985d12
4 changes: 3 additions & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
const php = provideCompletionItemsGenerator('php', htmlRegex);
const vue = provideCompletionItemsGenerator('vue', htmlRegex);
const twig = provideCompletionItemsGenerator('twig', htmlRegex);
const md = provideCompletionItemsGenerator('md', htmlRegex);
Copy link
Owner

@zignd zignd Jun 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace md with markdown. It's the correct language id and without this properly set the extension will not work for Markdown.

Copy link
Contributor Author

@cvharris cvharris Jun 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought it was simply referring to the file extension. Let me know if that's enough.

const tsReact = provideCompletionItemsGenerator('typescriptreact', jsxRegex);
const js = provideCompletionItemsGenerator('javascript', jsxRegex)
const jsReact = provideCompletionItemsGenerator('javascriptreact', jsxRegex);
Expand All @@ -126,6 +127,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
context.subscriptions.push(php);
context.subscriptions.push(vue);
context.subscriptions.push(twig);
context.subscriptions.push(md);
context.subscriptions.push(tsReact);
context.subscriptions.push(js);
context.subscriptions.push(jsReact);
Expand All @@ -136,4 +138,4 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
export function deactivate(): void {
}

// TODO: Look for CSS class definitions automatically in case a new file is added to the workspace. I think the API does not provide and event for that. Maybe I should consider opening a PR.
// TODO: Look for CSS class definitions automatically in case a new file is added to the workspace. I think the API does not provide and event for that. Maybe I should consider opening a PR.