Skip to content

Fix #37 in development environment.#47

Merged
jhilden merged 4 commits intozweilove:masterfrom
kruszczynski:undebug_in_development
Nov 27, 2014
Merged

Fix #37 in development environment.#47
jhilden merged 4 commits intozweilove:masterfrom
kruszczynski:undebug_in_development

Conversation

@kruszczynski
Copy link

This fixes issue #37 and is a much nicer implementation of #42. When in development and debug option is not specified it'll add debug: false option to split stylesheets since we only need them in < IE9. This speeds up debugging IE in development (code edits are not necessary).

@jhilden
Copy link
Contributor

jhilden commented Nov 25, 2014

looks very good. thanks a lot @kruszczynski

The only thing missing would be tests for the new behavior: https://github.com/zweilove/css_splitter/blob/master/test/unit/helpers/css_splitter/application_helper_test.rb

@jhilden
Copy link
Contributor

jhilden commented Nov 25, 2014

also, a little sentence in the README and the CHANGELOG would be good.

@kruszczynski
Copy link
Author

@jhilden I've changed README, and added tests. Also, I went for 0.4.1 version name in CHANGELOG.

jhilden added a commit that referenced this pull request Nov 27, 2014
@jhilden jhilden merged commit a45245f into zweilove:master Nov 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants