Address issue with comment handling in the splitter#5
Merged
jhilden merged 1 commit intozweilove:masterfrom Jan 12, 2013
Merged
Address issue with comment handling in the splitter#5jhilden merged 1 commit intozweilove:masterfrom
jhilden merged 1 commit intozweilove:masterfrom
Conversation
jhilden
added a commit
that referenced
this pull request
Jan 12, 2013
Address issue with comment stripping in the splitter
Contributor
|
Looks good. And thank you especially for the great test cases! Our lib ist still dramatically "undertested". |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will fix an issue that destroys CSS files that contain protocol independent urls (for example:
background-image: url(//assets.myserver.com/asset.png)).It also addresses the issue of wrongfully parsed multiline comments.
Not that this changes the current behavior as it will no longer remove
//comments. This should be the correct behavior since//is not a valid CSS comment.