Skip to content

Have Selector::isValid() actually return a bool #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oliverklee opened this issue Mar 1, 2025 · 0 comments · Fixed by #1174
Closed

Have Selector::isValid() actually return a bool #1043

oliverklee opened this issue Mar 1, 2025 · 0 comments · Fixed by #1174
Assignees
@oliverklee
Labels
bug cleanup
Milestone
9.0.0: Drop suppo...

Comments

@oliverklee
Copy link
Collaborator

Currently, is returns int<0, max>|false.

We also need to add test coverage for this method and add a native return type declaration.
oliverklee added a commit that referenced this issue Mar 1, 2025
@oliverklee
[TASK] Add more native type declarations for Selector
b737091 
The return type of `::isValid()` cannot use a native
return type declaration yet as the method's return values
currently are of a different type (#1043).

Part of #811
@oliverklee oliverklee mentioned this issue Mar 1, 2025
Merged
oliverklee added a commit that referenced this issue Mar 1, 2025
@oliverklee
[TASK] Add more native type declarations for Selector
411bd9e 
The return type of `::isValid()` cannot use a native
return type declaration yet as the method's return values
currently are of a different type (#1043).

Part of #811
JakeQZ pushed a commit that referenced this issue Mar 1, 2025
@oliverklee
[TASK] Add more native type declarations for Selector (#1044)
50045f7 
The return type of `::isValid()` cannot use a native
return type declaration yet as the method's return values
currently are of a different type (#1043).

Part of #811
@oliverklee oliverklee self-assigned this Mar 16, 2025
oliverklee added a commit that referenced this issue Mar 16, 2025
@oliverklee
[BUGFIX] Fix the return type of Selector::isValid()
4f80f1e 
Fixes #1043
Part of #811
@oliverklee oliverklee mentioned this issue Mar 16, 2025
Merged
oliverklee added a commit that referenced this issue Mar 16, 2025
@oliverklee
[BUGFIX] Fix the return type of Selector::isValid()
db81d31 
Fixes #1043
Part of #811
@JakeQZ JakeQZ closed this as completed in 4d965b3 Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverklee oliverklee

Labels
bug cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Fix the return type of Selector::isValid() MyIntervals/PHP-CSS-Parser
1 participant
@oliverklee