Skip to content

[TASK] Add to UML diagram that Selector implements Renderable #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

oliverklee
Copy link
Collaborator

Followup to #1017

@coveralls
Copy link

Coverage Status

coverage: 52.82%. remained the same
when pulling 4c8af80 on docs/renderable-in-uml
into 12afe20 on main.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be some other updates to make to the diagram in light of recent changes, e.g. introduction of CSSListItem interface. And should traits be included in the diagram (e.g. CommentContainer)?

@JakeQZ JakeQZ merged commit 8ea11a4 into main Mar 29, 2025
21 checks passed
@JakeQZ JakeQZ deleted the docs/renderable-in-uml branch March 29, 2025 19:28
@oliverklee
Copy link
Collaborator Author

And should traits be included in the diagram (e.g. CommentContainer)?

No, as far as class structures are concerned, traits do not really exists - for example, instanceof does not recognize traits. With this perspective, they are an implementation detail to avoid copy'n'pasting code.

@oliverklee
Copy link
Collaborator Author

There might be some other updates to make to the diagram in light of recent changes, e.g. introduction of CSSListItem interface.

Yes, indeed. Would you be willing to take care of that?

@JakeQZ
Copy link
Collaborator

JakeQZ commented Mar 30, 2025

Yes, indeed. Would you be willing to take care of that?

I have no suitable tool. All I'd be able to do is commit a change on a branch, and see how it looks on GitHub...

@oliverklee
Copy link
Collaborator Author

All I'd be able to do is commit a change on a branch, and see how it looks on GitHub...

Actually, that's what I do too. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants