Fix uploads getting stuck #2309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2019 00:48
Codecov Report
@@ Coverage Diff @@
## master #2309 +/- ##
=========================================
+ Coverage 5.89% 5.92% +0.02%
=========================================
Files 237 237
Lines 11348 11326 -22
Branches 1019 1019
=========================================
+ Hits 669 671 +2
+ Misses 10627 10603 -24
Partials 52 52
Continue to review full report at Codecov.
|
|
Now get past "receiving shared images", but fails when it's trying to upload (from home screen). |
|
@domdomegg Thanks for testing it. Uploads are not failing for me. :( I tried camera and gallery uploads from the home page and also from nearby maps. I have added more logs and have fixed some existing logs to make debugging easier. Can you retest and share logs. :) |
|
|
Noticed this this toast now:
|
|
@domdomegg The upload failed because of It's an issue that has been bugging us since we made changes for 2FA integration.
If the app is no longer getting stuck while initiating an upload, we can probably merge this to master. :) |
I have created a new issue for this #2321. The error looks unrelated to this PR. I will raise a separate PR to fix it. |
|
Tested this with a Nexus S emulator running API 27. There is an issue with the custom image picker library that I did not notice before this - there is no way to upload from an external image library (e.g. Google Photos) via the in-app Gallery button. It automatically takes you to local storage, and the up button in the action bar just takes you back to contributions activity. To get around that, I went to Google Photos > Share, and uploaded an image that way. Got stuck permanently on "receiving shared content", with the logs below. Uploading from local storage works, however. Shall I merge this first, and you can submit a separate PR for the Google Photos fix? @maskaravivek |
This was referenced Jan 24, 2019
|
Merging this after conversation with @maskaravivek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes null file path issue because of #2287.
What changes did you make and why?
@domdomegg reported an issue with the app getting stuck on the "receiving shared images.." screen. I missed the comment and finally found out that the issue might be happening for everyone.
Tests performed (required)
Nearby and normal uploads work well.