-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Bug]: Back arrow still present on top-level activity (Contributions) #4950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
madhurgupta10
added a commit
to madhurgupta10/apps-android-commons
that referenced
this issue
Apr 30, 2022
madhurgupta10
added a commit
to madhurgupta10/apps-android-commons
that referenced
this issue
Apr 30, 2022
misaochan
pushed a commit
that referenced
this issue
May 2, 2022
this looks like fixed with #4952 |
misaochan
added a commit
that referenced
this issue
Aug 8, 2022
* Fix string for custom selector * Fix bug #4950 back arrow still present on top-level activity (#4952) * Fix bug #4949 by correctly setting previous db version number (#4956) * Fix bug #4949 by correctly setting previous db version number * Fix failing tests * Fix bug #4959 by correctly setting previous db version number and updating the current db version (#4960) * Fix bug #4957 (#4961) * Update library to new version that handles older Java VMs Fixes #4972 I believe. * Versioning for v4.0.0 * Changelog for v4.0.0 * Fix bug #4984 Added queries for package name for Android API 30+ (#4987) * Update mapbox sdk version (#4989) * Versioning for v4.0.1 * Changelog for v4.0.1 * Remove network type information from NetworkUtils (#4996) * Remove network type information from NetworkUtils * Ignore dependent tests * Fix #4992 invert the equals condition to be null safe (#4995) * Fix java.lang.NullPointerException for username in ContributionBoundaryCallback (#5003) * Fix failing tests for PR #5003 (#5004) * Fix java.lang.NullPointerException for username in ContributionBoundaryCallback * Fix failing tests * Update Room DB Version (#5011) * Fix #5001 (#5010) * Fix DB update issue (#5016) * [WIP] Fix both timezone problem and saved date problem (#5019) * Fix both timezone problem and saved date problem * Fixaccidental test code and add comments * Add issue link to the comments * Fix format issue and null checks * Versioning for v4.0.2 * Changelog for v4.0.2 * Add "Report Violation" menu option (#5025) * Add "Report Violation" menu option * Update email template * Update email address * Fixed typo Co-authored-by: Josephine Lim <josephinelim86@gmail.com> * Versioning for v4.0.3 * Changelog for v4.0.3 Co-authored-by: Josephine Lim <josephinelim86@gmail.com> Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com> Co-authored-by: neslihanturan <tur.neslihan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
If you load the app and select an image to view, you can return to the top-level activity (Contributions) by tapping the up button (back arrow). But the up button remains present once you are in Contributions again.
Steps to reproduce
Expected behaviour
Up button should not be visible in top level activity
Actual behaviour
Up button remains visible
Device name
Samsung Galaxy S20 FE
Android version
Android 11
Commons app version
master and 4.0-release (prodRelease build variant)
Device logs
No response
Screen-shots
Would you like to work on the issue?
No response
The text was updated successfully, but these errors were encountered: