Fix both timezone problem and saved date problem

[neslihanturan]

Description (required)

Fixes #1971

• ExifInterface.TAG_DATETIME_ORIGINAL used instead of getDateTime() so that we will reach to date of creation of file
• Date is stored in string form instead of Date data type, so timezones are never involved

Tests performed (required)

Tested ProdDebug on Pixel 5 with API level 31

Here is the test upload: https://commons.wikimedia.org/wiki/File%3ACommons_app_exif_issue.jpg

The same upload without changes in this PR: https://commons.wikimedia.org/w/index.php?title=File:Vinkeveen,_Heilig_Hart_van_Jezus_(32).jpg

Auto added categories is not tested yet.

[neslihanturan]

Thanks for the reviews @nicolas-raoul :) Now ready to be tested

[whym]

getAttribute may return null, so I think you will need to check that first.

(I would personally prefer checking the size than catching IndexOutOfBoundsException, but that's not a huge issue anyway.)

[whym]

Here is a sample file without EXIF - trying to upload this gave a NullPointerException when I tested.

[misaochan]

Thanks for the PR @neslihanturan ! I will test ASAP, but in the meantime I did notice that the format of the date that we are outputting in the template at https://commons.wikimedia.org/wiki/File%3ACommons_app_exif_issue.jpg "2022:07:03 (according to Exif data)" is somewhat unusual. @nicolas-raoul @whym do we know if this format is acceptable for the template?

It definitely doesn't work with the category, as Photographs taken on 2022:07:03 leads to an invalid link (but I am aware that that is still work in progress).

[whym]

Yeah, the end result should look like "{{According to Exif data|2022-07-03}}". (=joined by "-", and zero padded) In the source code it will look like

-            String dateCreatedString = year+":"+month+":"+day;
+            String dateCreatedString = String.format("%04d-%02d-%02d", Integer.parseInt(year), Integer.parseInt(month), Integer.parseInt(day));

(combining the preceding 3 parseInt lines into one)

This would be in line with the "yyyy-MM-dd" format already used elsewhere in the app's codebase.

(That said, the template could be made more flexible to accept different formats, if there is a legitimate need to do so, by submitting an edit request at https://commons.wikimedia.org/wiki/Template_talk:According_to_Exif_data .)

[nicolas-raoul]

Here is my test with a picture taken after 3pm JST: https://commons.wikimedia.org/wiki/File:Motomiya,_Tsurumi.jpg
As you can see {{According to Exif data|2022:07:12}} was generated, which is the right date but with a formatting that does not seem to fit the category. So I agree with Jo and Whym :-)

[nicolas-raoul]

Tested, it works: https://commons.wikimedia.org/wiki/File:Pickles_for_automatic_sale_in_Zushi.jpg
Thanks a lot Nes! :-)

[whym]

Looks good to me. I tested it again with betaDebug and prodDebug and there was no NullPointerException anymore. Thanks @neslihanturan !

[misaochan]

Tested with prodDebug on Samsung Galaxy S20FE, works well for me. Nice work @neslihanturan ! :) I uploaded https://commons.wikimedia.org/wiki/File:Roma_Street_Parkland.jpg with edits (for Issue 1) and the correct date is used. I also uploaded a photo taken at 4.25pm (my timezone is +10 UTC) and the date is also correct there https://commons.wikimedia.org/wiki/File:Koala_22.jpg .