Skip to content

[Bug]: Compile error when building with prodRelease #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
misaochan opened this issue May 24, 2022 · 4 comments · Fixed by #4975
Closed

[Bug]: Compile error when building with prodRelease #4972

misaochan opened this issue May 24, 2022 · 4 comments · Fixed by #4975

Comments

@misaochan
Copy link
Member

misaochan commented May 24, 2022

Summary

Building the 4.0-release branch with the prodRelease build variant encounters an error as of today (24 May). It did not encounter any errors the last time I did it (about 2 weeks ago), hence the issue probably lies with a deprecation or changes to the relevant external library.

Commenting out the line implementation("io.github.coordinates2country:coordinates2country-android:1.2") { exclude group: 'com.google.android', module: 'android' } in build.gradle solves the compile error, but might introduce other issues.

Steps to reproduce

Build the 4.0-release branch with the prodRelease build variant. Do not test with prodDebug, this does not run minifyWithProguard and therefore does not cause the same issue.

Expected behaviour

Compile

Actual behaviour

Error

Device name

n/a

Android version

all

Commons app version

4.0-release branch

Device logs

:app:minifyProdReleaseWithProguard
class [META-INF/versions/9/module-info.class] unexpectedly contains class [module-info]
java.io.IOException: Can't read [C:\Users\misao\.gradle\caches\transforms-3\f01f3ac3a037e688ad96109d2702c702\transformed\jetified-coordinates2country-android-1.2.jar(;;;;;;;**.class)] (Can't process class [io/github/coordinates2country/Coordinates2Country.class] (Unsupported version number [55.0] (maximum 54.0, Java 10)))
Unsupported version number [55.0] (maximum 54.0, Java 10)

Screen-shots

No response

Would you like to work on the issue?

No response

@madhurgupta10
Copy link
Collaborator

@misaochan Did you try after deleting the cached packages and build folder?

@misaochan
Copy link
Member Author

Yes, doesn't solve the issue. :/

@misaochan
Copy link
Member Author

Hi @nicolas-raoul , any thoughts on what the issue could be? As you appear to be the author of https://github.com/coordinates2country/coordinates2country-android :)

@nicolas-raoul
Copy link
Member

I can reproduce the issue.

I built that library using openjdk 11.0.12 2021-07-20 LTS or earlier.

If there is anything I can change on the library side to fix it, I am happy to do it. :-)
The answers at https://stackoverflow.com/questions/54147275/move-to-openjdk-11-but-compile-in-java-8 sound may be relevant?

nicolas-raoul added a commit that referenced this issue May 25, 2022
nicolas-raoul added a commit to coordinates2country/coordinates2country-android that referenced this issue May 26, 2022
misaochan pushed a commit that referenced this issue May 28, 2022
misaochan added a commit that referenced this issue Aug 8, 2022
* Fix string for custom selector

* Fix bug #4950 back arrow still present on top-level activity (#4952)

* Fix bug #4949 by correctly setting previous db version number (#4956)

* Fix bug #4949 by correctly setting previous db version number

* Fix failing tests

* Fix bug #4959 by correctly setting previous db version number and updating the current db version (#4960)

* Fix bug #4957 (#4961)

* Update library to new version that handles older Java VMs

Fixes #4972 I believe.

* Versioning for v4.0.0

* Changelog for v4.0.0

* Fix bug #4984 Added queries for package name for Android API 30+ (#4987)

* Update mapbox sdk version (#4989)

* Versioning for v4.0.1

* Changelog for v4.0.1

* Remove network type information from NetworkUtils (#4996)

* Remove network type information from NetworkUtils

* Ignore dependent tests

* Fix #4992 invert the equals condition to be null safe (#4995)

* Fix java.lang.NullPointerException for username in ContributionBoundaryCallback (#5003)

* Fix failing tests for PR #5003 (#5004)

* Fix java.lang.NullPointerException for username in ContributionBoundaryCallback

* Fix failing tests

* Update Room DB Version (#5011)

* Fix #5001 (#5010)

* Fix DB update issue (#5016)

* [WIP] Fix both timezone problem and saved date problem (#5019)

* Fix both timezone problem and saved date problem

* Fixaccidental test code and add comments

* Add issue link to the comments

* Fix format issue and null checks

* Versioning for v4.0.2

* Changelog for v4.0.2

* Add "Report Violation" menu option (#5025)

* Add "Report Violation" menu option

* Update email template

* Update email address

* Fixed typo

Co-authored-by: Josephine Lim <josephinelim86@gmail.com>

* Versioning for v4.0.3

* Changelog for v4.0.3

Co-authored-by: Josephine Lim <josephinelim86@gmail.com>
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
Co-authored-by: neslihanturan <tur.neslihan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants