Links added to TextView about_upload_to in aboutActivity #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1326 +/- ##
======================================
Coverage 3.3% 3.3%
======================================
Files 128 128
Lines 6837 6837
Branches 669 669
======================================
Hits 226 226
Misses 6596 6596
Partials 15 15Continue to review full report at Codecov.
|
misaochan
requested changes
Mar 25, 2018
Member
misaochan
left a comment
There was a problem hiding this comment.
Please see question on issue.
misaochan
approved these changes
Apr 2, 2018
Member
|
Sorry it took so long to get back to you! Happy to merge when conflicts fixed. :) |
Contributor
Author
|
@misaochan I have fixed the merged conflicts :) |
neslihanturan
pushed a commit
that referenced
this pull request
Apr 16, 2018
* used CDATA * Improvements in Notification Activity (#1374) * Improvements in Notification Activity * Update NotificationActivity.java * Share feature (#1338) * added share app feature in About * added share app feature in About * a small fix * Use custom tabs for nearby web views (#1347) * Localisation updates from https://translatewiki.net. * Fix for issue #1380 Improved Notification UI (#1387) * Links added to TextView about_upload_to in aboutActivity (#1326) * Added the link in about_upload_to textfield * Merge conflicts resolved * Removed the extra textView * Fix re-enabling delete button if the action is canceled. * Keep delete button enabled until a reason is given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1306
I have linked the textView about_upload_to to https://commons.wikimedia.org/wiki/Commons:Upload url.
Tests performed
Tested on Pixel XL api level 26, with betaRelease.
Screenshots showing what changed