Share feature #1338
Merged
Share feature #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
=========================================
- Coverage 3.73% 3.72% -0.01%
=========================================
Files 127 127
Lines 6054 6065 +11
Branches 588 588
=========================================
Hits 226 226
- Misses 5813 5824 +11
Partials 15 15
Continue to review full report at Codecov.
|
Member
|
Sorry for the delayed review. The screenshot and code looks good to me, happy to merge pending a successful manual test. |
misaochan
approved these changes
Mar 28, 2018
Contributor
Author
|
Okay...no problem :-)
…On Wed, Mar 28, 2018 at 4:27 PM, Josephine Lim ***@***.***> wrote:
Sorry for the delayed review. The screenshot and code looks good to me,
happy to merge pending a successful manual test.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1338 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfShUSWoN34CLeg3-vW6n_ZPRvRj_nS6ks5ti2yLgaJpZM4SwvU->
.
|
maskaravivek
approved these changes
Mar 28, 2018
Contributor
|
Thanks, @Mansi449 this works perfectly. :) |
neslihanturan
pushed a commit
that referenced
this pull request
Apr 16, 2018
* used CDATA * Improvements in Notification Activity (#1374) * Improvements in Notification Activity * Update NotificationActivity.java * Share feature (#1338) * added share app feature in About * added share app feature in About * a small fix * Use custom tabs for nearby web views (#1347) * Localisation updates from https://translatewiki.net. * Fix for issue #1380 Improved Notification UI (#1387) * Links added to TextView about_upload_to in aboutActivity (#1326) * Added the link in about_upload_to textfield * Merge conflicts resolved * Removed the extra textView * Fix re-enabling delete button if the action is canceled. * Keep delete button enabled until a reason is given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1284
Added share icon in About page through menu inflater. On click of this icon, the google play store link of the app can be sent via any application through which text messages can be sent.
Tests performed
Tested on Motorola Moto G(5) (Android 7.0, API 24)