Fixes issue #1380 Changed Notification UI. #1387
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1387 +/- ##
======================================
Coverage 3.32% 3.32%
======================================
Files 128 128
Lines 6801 6801
Branches 657 657
======================================
Hits 226 226
Misses 6560 6560
Partials 15 15
Continue to review full report at Codecov.
|
|
Hi @Jatin0312 , just tested this - I like the padding, but the whitespace issue persists for me. It is mostly just the deletion nomination messages that cause the problem (the ones that start with "File: xxx.jpg has been..."), so in order to see if your whitespace stripping works, you need to look at a deletion message. If you don't have any, what you can do is to upload a picture and then nominate your own picture for deletion. That will generate a suitable message for testing. :) |
|
Ok thanks I will look into it :) |
|
@misaochan I nominated many photos for deletion but still was not able to generate any notifications. |
|
@Jatin0312 Could you link your Wikimedia user talk page please? |
|
https://commons.m.wikimedia.beta.wmflabs.org/wiki/User:Codedoper0312 This the link of my user talk page. |
|
I nominated https://commons.wikimedia.beta.wmflabs.org/wiki/File:Taj_mahal_3.jpg for deletion, try and see if you get any notifications? We usually test notifications on the actual Commons server, but I don't see any reason why beta wouldn't work. |
|
Edit: Oh, wait, that one's not yours. Sorry. :/ How about you create a new account and see if nominating via the other account works (instead of nominating your own)? |
|
Ok I will check that. :) |
|
I did nominate images from different account It's working fine I guess.
|
|
Hmm, not sure why some of my notifications still have excess whitespace. I guess we can go with merging this PR since it is an improvement anyway, and we can investigate further later on. :) Thanks! |
* used CDATA * Improvements in Notification Activity (#1374) * Improvements in Notification Activity * Update NotificationActivity.java * Share feature (#1338) * added share app feature in About * added share app feature in About * a small fix * Use custom tabs for nearby web views (#1347) * Localisation updates from https://translatewiki.net. * Fix for issue #1380 Improved Notification UI (#1387) * Links added to TextView about_upload_to in aboutActivity (#1326) * Added the link in about_upload_to textfield * Merge conflicts resolved * Removed the extra textView * Fix re-enabling delete button if the action is canceled. * Keep delete button enabled until a reason is given.
Description
Fixes #1380
Added padding for title and removed extra spaces from title text.
Tests performed
Moto g4 plus Android 7.0.0
Screenshots showing what changed