Open map of place where picture was taken #1360

tanvidadu · 2018-03-24T10:36:25Z

Description

Fixes #1126

Added a Floating Button which open Google map app with street view showing the location specified by the coordinates.

Tests performed

Tested on API level 24 , Samung J7 max with betaDebug.

Screenshots showing what changed

misaochan · 2018-04-02T08:49:28Z

Looks good to me, what do you think @neslihanturan ?

neslihanturan · 2018-04-16T13:26:19Z

I have tested this one, but I have two questions:
1- If this get merged, where we will put zoom button and vice versa:)
2- This should be disabled whenever location information isn't exist in photo

tanvidadu · 2018-04-16T13:45:36Z

when one of the pr either Zoom #1300 or Open map of place where picture was taken #1360 gets merged I will immediately submit another patch to convert them to nested FAB. (futuresimple/android-floating-action-button#22.)
when coordinates are not present a toast saying "Coordinates were not specified during image selection" will be displayed to user

misaochan · 2018-04-16T14:51:38Z

I think it might be better to hide the button entirely if coordinates are not present? :)

tanvidadu · 2018-04-16T18:47:39Z

I think it will be more intuitive to hide the FAB button I will change the fix accordingly ! thanks :)

tanvidadu · 2018-04-17T13:06:21Z

@misaochan @neslihanturan I have made the required changes ! thanks :)

codecov-io · 2018-04-17T13:32:10Z

Codecov Report

Merging #1360 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1360      +/-   ##
=========================================
- Coverage    3.21%   3.19%   -0.02%     
=========================================
  Files         132     132              
  Lines        7091    7131      +40     
  Branches      682     687       +5     
=========================================
  Hits          228     228              
- Misses       6848    6888      +40     
  Partials       15      15

Impacted Files	Coverage Δ
...java/fr/free/nrw/commons/upload/ShareActivity.java	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693c37f...0c44da0. Read the comment docs.

tanvidadu · 2018-04-26T19:42:19Z

I have added nested FAB in this pull request. Screenshots are below :

misaochan · 2018-04-27T07:10:17Z

Looks good to me! 👍 Happy to merge if manual testing passes.

neslihanturan · 2018-04-30T09:35:27Z

@tanvidadu great job, I have a few more suggestions and we are done.

Can you please give an information messaje when there is no location information provided and user clicked to map icon?
Can we use a plus icon on fab, instead of arrow, similar to our new nearby look. And can we change FAB colors as in nearby FABs, to make our app consistent.

misaochan · 2018-04-30T09:45:12Z

@neslihanturan , sorry, I personally think that the up arrow is more appropriate than a plus button. :) Because in Nearby the FAB is for uploading (i.e. "adding") something, whereas in this case it is just a view (zoom and coordinates).

Maybe if the up arrow isn't suitable, we can think of a 3rd option?

I agree re: displaying a toast if there is no location information. I'm also good with the FAB color change.

neslihanturan · 2018-04-30T12:00:34Z

You might be right @misaochan , but according to material design https://material.io/guidelines/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button , doesn't matter if you mean "add" or not, they use plus as example. So it feels more natural to me. I think meaning of plus is not "add", instead "expand". What do you think?

tanvidadu · 2018-04-30T14:58:24Z

I forgot to un-comment a condition that allows the map option to be present only when coordinates are present, which will fix the first issue.
I found the up arrow more suitable but I am happy to change it after @misaochan opinion on it. I will add the FAB color change feature similar to nearby.

misaochan · 2018-04-30T15:16:12Z

Ah, interesting! In that case yes, I'm good with changing it to a "+". :)

nicolas-raoul · 2018-05-01T05:14:40Z

Sorry I am late to the discussion, but personally I also preferred the arrow haha
The guideline page actually has examples with something else than a +, it seems:

The Facebook Messenger app was using the "+" before, but they replaced it with the "text bubble" symbol above, I guess users were finding the "+" confusing:

misaochan · 2018-05-01T08:57:51Z

Haha, poor Tanvi! How about we just leave the arrow for now and merge this PR after the color change and coordinate checks are implemented? We can always continue discussion and change it later if desired.

tanvidadu · 2018-05-02T08:24:23Z

I will make the required changes 👍

misaochan · 2018-05-04T16:38:08Z

@neslihanturan Shall we go ahead and merge?

neslihanturan · 2018-05-07T09:57:54Z

Great job @tanvidadu !

* Intent to map added * Merge conflicts resolved * Added the functionality to hide FAB incase of null coordinate * Merge Conflict resolved * Improve pr quality * Improve Quality * Added nested FAB animations * Nested FAB implemented * Improve Quality * Added up arrow * Javadocs Added

…rby (#1495) * Localisation updates from https://translatewiki.net. * Integrate API for displaying featured images (#1456) * Integrate API for displaying featured images * Add pagination and refactor code so that it can be reused for category images * Add license info to the images * Fix author view * Remove unused values * Fix minor issues with featured images * Fix null license url issue * Remove some log lines * Fix back navigation issue * fix tests * fix test inits * Gracefully handling various error situations * Added java docs * Update pull_request_template.md (#1476) * Update pull_request_template.md * Remove Javadocs mention * Added required/optional notes * resolves #1464 : MediaDataExtractor is making inefficient (redundant) server calls (#1496) * Open map of place where picture was taken (#1360) * Intent to map added * Merge conflicts resolved * Added the functionality to hide FAB incase of null coordinate * Merge Conflict resolved * Improve pr quality * Improve Quality * Added nested FAB animations * Nested FAB implemented * Improve Quality * Added up arrow * Javadocs Added * Add nearby tutorial (#1467) * Add dependency for MaterialShowcase * Add actionview class to get a reference to material showcase * Create a NearbyMaterialShowcaseSequence class * Apply sequence steps * Add first three steps of nearby showcase * Add sequence id constants to make sure they will be displayed only once * Add last step of sequence to explain plus fab * Create an object to prevent customize all sequences every time * Fix typo * Code cleanup * Add strings to strings.xml * Code cleanup * Revert irrelevant change * Revert irrelevant change * Remove showcaseview for recenter button * Use single showcaseView instead of sequence * Add single showcase view insted of sequence to be able to edit text style * Make sure it will be displayed only once * Cleanup * Update strings * Change dismiss text style * CONTRIBUTING: fix formatting of the gist of the guidelines (#1453) * CONTRIBUTING: fix formatting of the gist of the guidelines First level headings for a gist seems to be overkill. So, replace first level headings with an ordered-list which sounds more meaningful. * CONTRIBUTING: specify clearly that 'blame' is a feature of "Git" The contributing file specifies about the ability to know who wrote something without the need of @author javadoc tags but incorrectly attributes the feature to GitHub. Correctly attribute the feature to where it belongs, Git, and specify the name of the feature to help users easily take advantage of it. * Feature/switch to butterknife (#1494) * Implemented butterknife in MediaDetailFragment [issue #1491] * Implemented butterknife in MediaDetailPagerFragment [[issue #1491]] * post merge upstream master wip [[issue #1491]] * Localisation updates from https://translatewiki.net. * Bug fix #1504 (#1506) * Bug fix #1504 * Filtered messages with ConnectException [issue #1504] * A generalised message for exceptions in Nearby Activity [issue #1504] * Localisation updates from https://translatewiki.net. * Fix security exception crash while accessing network location provider (#1498) * Fix security exception crash while accessing network location provider * Added java docs * Localisation updates from https://translatewiki.net. * Log P18 edits to wikidata corresponding wikidata entity on uploading a nearby image * Added java docs * Fix test build * Refresh nearby * Refresh nearby list on successful edit * Java docs * Make authenticated wikidata edits * Updated toast message to show entity name that was edited

tanvidadu force-pushed the map branch from 7832c23 to 2aa4ce7 Compare April 17, 2018 13:05

commons-app deleted a comment Apr 17, 2018

tanvidadu force-pushed the map branch from b2c5313 to 7f6aaa1 Compare April 25, 2018 17:45

commons-app deleted a comment Apr 25, 2018

tanvidadu force-pushed the map branch from 7f6aaa1 to 880140d Compare April 26, 2018 19:36

commons-app deleted a comment Apr 26, 2018

tanvidadu force-pushed the map branch from 880140d to 2bc0d8d Compare April 30, 2018 17:09

commons-app deleted a comment Apr 30, 2018

commons-app deleted a comment May 2, 2018

tanvidadu added 2 commits May 4, 2018 17:20

Intent to map added

e553d7f

Merge conflicts resolved

c2468f8

tanvidadu added 9 commits May 4, 2018 17:21

Added the functionality to hide FAB incase of null coordinate

0c08382

Merge Conflict resolved

4184721

Improve pr quality

45d7a68

Improve Quality

cb699c0

Added nested FAB animations

88166e6

Nested FAB implemented

bbec1d0

Improve Quality

026c57d

Added up arrow

bbd80bc

Javadocs Added

0c44da0

tanvidadu force-pushed the map branch from ebab8c7 to 0c44da0 Compare May 4, 2018 11:55

commons-app deleted a comment May 4, 2018

neslihanturan merged commit 4f6b791 into commons-app:master May 7, 2018

tanvidadu deleted the map branch August 3, 2018 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Open map of place where picture was taken #1360

Open map of place where picture was taken #1360

tanvidadu commented Mar 24, 2018

misaochan commented Apr 2, 2018

neslihanturan commented Apr 16, 2018

tanvidadu commented Apr 16, 2018 •

edited

Loading

misaochan commented Apr 16, 2018

tanvidadu commented Apr 16, 2018

tanvidadu commented Apr 17, 2018

codecov-io commented Apr 17, 2018 •

edited

Loading

tanvidadu commented Apr 26, 2018

misaochan commented Apr 27, 2018 •

edited

Loading

neslihanturan commented Apr 30, 2018

misaochan commented Apr 30, 2018 •

edited

Loading

neslihanturan commented Apr 30, 2018

tanvidadu commented Apr 30, 2018 •

edited

Loading

misaochan commented Apr 30, 2018

nicolas-raoul commented May 1, 2018

misaochan commented May 1, 2018

tanvidadu commented May 2, 2018 •

edited

Loading

misaochan commented May 4, 2018

neslihanturan commented May 7, 2018

Open map of place where picture was taken #1360

Open map of place where picture was taken #1360

Conversation

tanvidadu commented Mar 24, 2018

Description

Tests performed

Screenshots showing what changed

misaochan commented Apr 2, 2018

neslihanturan commented Apr 16, 2018

tanvidadu commented Apr 16, 2018 • edited Loading

misaochan commented Apr 16, 2018

tanvidadu commented Apr 16, 2018

tanvidadu commented Apr 17, 2018

codecov-io commented Apr 17, 2018 • edited Loading

Codecov Report

tanvidadu commented Apr 26, 2018

misaochan commented Apr 27, 2018 • edited Loading

neslihanturan commented Apr 30, 2018

misaochan commented Apr 30, 2018 • edited Loading

neslihanturan commented Apr 30, 2018

tanvidadu commented Apr 30, 2018 • edited Loading

misaochan commented Apr 30, 2018

nicolas-raoul commented May 1, 2018

misaochan commented May 1, 2018

tanvidadu commented May 2, 2018 • edited Loading

misaochan commented May 4, 2018

neslihanturan commented May 7, 2018

tanvidadu commented Apr 16, 2018 •

edited

Loading

codecov-io commented Apr 17, 2018 •

edited

Loading

misaochan commented Apr 27, 2018 •

edited

Loading

misaochan commented Apr 30, 2018 •

edited

Loading

tanvidadu commented Apr 30, 2018 •

edited

Loading

tanvidadu commented May 2, 2018 •

edited

Loading