Add information icon action Fiixes #2055 2.9.0: the 'i' icon in nearby doesn't do anything #2057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug fix issue commons-app#1826 Changes made : -Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe * review suggested changes *Code formatting *Extracted out the index of pipe in a variable *Added issue link in comments
* Remove libraries section from README * Add wiki link to "libraries used" to README
ashishkumar468
approved these changes
Dec 1, 2018
maskaravivek
approved these changes
Dec 1, 2018
Codecov Report
@@ Coverage Diff @@
## 2.9-release #2057 +/- ##
==============================================
+ Coverage 4.07% 4.07% +<.01%
==============================================
Files 224 224
Lines 11329 11327 -2
Branches 1046 1046
==============================================
Hits 462 462
+ Misses 10833 10831 -2
Partials 34 34
Continue to review full report at Codecov.
|
|
Since this is approved by both of you, can someone please merge this? I don't prefer to merge my own PR. |
neslihanturan
pushed a commit
that referenced
this pull request
Dec 19, 2018
* Fix memory leak due to wikidata edit listener (#2048) * Fix bookmark crash fix (#2047) * Fix bookmark crash fix * Fix check for bookmark creator * Bug fix #2042 (#2056) * Bug fix #2042 * Added a snack with retry when api in AA fails * Increased connection timeouts in okhttpclient builder * added missing string resource * Bugfix/duplicate categories (#2080) * Increased timeout to 60 seconds * Bug fix #1550 * filter duplicate categories * Fix crash because of inactive fragment UI (#2046) * Fix crash because of inactive fragment UI * Add java docs * Add information icon action Fiixes #2055 2.9.0: the 'i' icon in nearby doesn't do anything (#2057) * Localisation updates from https://translatewiki.net. * Remove unused mediawiki api dependency (#1991) * Categories with pipe suffix (#1873) * Bug fix issue #1826 Changes made : -Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe * review suggested changes *Code formatting *Extracted out the index of pipe in a variable *Added issue link in comments * Remove libraries section from README (#1988) * Remove libraries section from README * Add wiki link to "libraries used" to README * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Use alert dialog instead of popup window, for nearby information * Revert irrelevant changes, sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #2055 2.9.0: the 'i' icon in nearby doesn't do anything
What changes did you make and why?
On some devices, ie. API 5.1.1, popup window's showAsDropDown() method doesn't work. Since we use alert dialog for showing information in app in general (as @maskaravivek noted) I decided to use Alert Dialog instead.
And unused codes are removed accordingly.
Tests performed (required)
Tested on prodDebug API 26