-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixing issue #2090 Searching night mode #2095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
======================================
Coverage 4.02% 4.02%
======================================
Files 226 226
Lines 11467 11467
Branches 1064 1064
======================================
Hits 461 461
Misses 10972 10972
Partials 34 34 Continue to review full report at Codecov.
|
Thanks for your first time contribution @pereiraJr :) I have made some notes, please consider them. By the way it can be nice adding before after UI comparisons for such UI changes There is a nice UI improvement. But you changed some of files you shouldn't. Whenever you fixed them we can review your PR again. |
As final decision, I request changes @pereiraJr :) |
After merging into master it doesn't seem to work for me:
Also as I was trying to get this to work I've made some improvements to the search UI (see #2189), which might have an impact on how this is implemented. Might make it easier actually, as both can have the same toolbar colours. Will handle merge conflicts if they happen if that is merged first, please tag me if needed. |
Searching for images or categories in night mode works but the words doesn't show neither the recent researches.
Fixes #2090 Searching on Night Mode
What changes did you make and why?
Ux changes to be more clean on night mode
Tests performed (required)
Exploratory testing
Screenshots showing what changed (optional - for UI changes)