Skip to content

Improve search UI #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Improve search UI #2189

merged 2 commits into from
Dec 21, 2018

Conversation

domdomegg
Copy link
Member

Description (required)

Fixes

  • "Search commons" text not being at the same horizontal alignment of all the other activities
  • Action bar being white, while all other activities have it as blue

Tests performed (required)

Tested 2.9.0-debug-improve-search-ui~895d8a97d on Galaxy Nexus (emulator) with API level 28.
Tested 2.9.0-debug-improve-search-ui~895d8a97d on Galaxy Nexus (emulator) with API level 25.
Tested 2.9.0-debug-improve-search-ui~895d8a97d on Samsung Galaxy S6 with API level 25.

Screenshots showing what changed

Before After
https://giphy.com/gifs/uBmSMFrRgIHuIJTYvx https://giphy.com/gifs/ctNcQJ2DtHiFKexuGe
screenshot_1545308833 screenshot_1545308902

@domdomegg domdomegg changed the title Improve search ui Improve search UI Dec 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #2189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2189   +/-   ##
======================================
  Coverage    5.71%   5.71%           
======================================
  Files         231     231           
  Lines       11595   11595           
  Branches     1079    1079           
======================================
  Hits          663     663           
  Misses      10877   10877           
  Partials       55      55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9274c0...895d8a9. Read the comment docs.

@neslihanturan
Copy link
Collaborator

Thanks @domdomegg tested both on dark and light theme, looks very nice.

@neslihanturan neslihanturan merged commit 96d5403 into commons-app:master Dec 21, 2018
@domdomegg domdomegg deleted the improve-search-ui branch December 23, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants