Categories related client API's migrated to retrofit #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@ilgazer you can click here to see the review status or cancel the code review job.
Codecov Report
@@ Coverage Diff @@
## backend-overhaul #3053 +/- ##
===================================================
+ Coverage 4.55% 4.71% +0.16%
===================================================
Files 260 261 +1
Lines 12261 12195 -66
Branches 1051 1043 -8
===================================================
+ Hits 558 575 +17
+ Misses 11664 11581 -83
Partials 39 39
Continue to review full report at Codecov.
|
|
@ilgazer Thanks for the PR. Nice work :) I didn't understand this comment.
|
|
I’m sorry for not being clear, the first 3 were merged into
searchCategories. I’m going to work on getCategoryImages getSubCategoryList
and getParentCategoryList today.
… |
maskaravivek
reviewed
Jul 5, 2019
| return Observable.empty(); | ||
| }) | ||
| .map(MwQueryPage::title) | ||
| .doOnEach(s->Timber.d("Category returned: %s", s)) |
There was a problem hiding this comment.
This logline can be removed before merging the PR. :)
Okay, great. Ideally |
Yes, feel free to delete the unused APIs. :) |
maskaravivek
approved these changes
Jul 5, 2019
|
I feel that those belong to the same CategoriesClient and CategoriesInterface. Would I be able to put them there while also having a separate PR? |
|
I am testing this PR right now. If my tests work then we can merge this PR as it is in |
|
Ok, I'Il write unit tests in the meantime :) |
|
Can you also remove unused code? |
maskaravivek
reviewed
Jul 5, 2019
fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones.
maskaravivek
approved these changes
Jul 5, 2019
maskaravivek
approved these changes
Jul 5, 2019
maskaravivek
pushed a commit
to maskaravivek/apps-android-commons
that referenced
this pull request
Jul 6, 2019
* Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical
maskaravivek
pushed a commit
to maskaravivek/apps-android-commons
that referenced
this pull request
Jul 7, 2019
* Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical
maskaravivek
pushed a commit
to maskaravivek/apps-android-commons
that referenced
this pull request
Jul 7, 2019
* Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical
maskaravivek
pushed a commit
to maskaravivek/apps-android-commons
that referenced
this pull request
Jul 10, 2019
* Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical
maskaravivek
pushed a commit
that referenced
this pull request
Jul 15, 2019
…Client (#3056) * With media client APIs migrated to retrofit (#2998) * With media client APIs migrated to retrofit * Add test cases and java docs * Fix test * Fix build * Fix build and other minor issues * Fix tests * Categories related client API's migrated to retrofit (#3053) * Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical * With media client APIs migrated to retrofit (#2998) * With media client APIs migrated to retrofit * Add test cases and java docs * Fix test * Fix build * Fix build and other minor issues * Fix tests * Categories related client API's migrated to retrofit (#3053) * Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical * OkHttpJsonApi#getMediaList migrated to retrofit (#3054) * Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController * getSubCategoryList and getParentCategoryList migrated to retrofit (#3055) * Migrated getSubCategoryList to retrofit * Migrated getParentCategoryList to retrofit * Removed obsolete functions * Added tests * Fixed small bugs * Migrated OkHttpJsonApiClient#getMedia and getPictureOfTheDay to MediaClient * Removed obsolete functions and added tests * Fixed merge errors * With media client APIs migrated to retrofit (#2998) * With media client APIs migrated to retrofit * Add test cases and java docs * Fix test * Fix build * Fix build and other minor issues * Fix tests * Categories related client API's migrated to retrofit (#3053) * Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical * OkHttpJsonApi#getMediaList migrated to retrofit (#3054) * Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController * getSubCategoryList and getParentCategoryList migrated to retrofit (#3055) * Migrated getSubCategoryList to retrofit * Migrated getParentCategoryList to retrofit * Removed obsolete functions * Added tests * Fixed small bugs * Consume login client from data client library (#2894) Fix actions for review client Use data client library for notifications With delete helper migrated to data client With wikidata edits With notifications and modifications migrated to data client With upload migrated to retrofit Delete unused code Reuse thank interface from the library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #3026 I'm migrating all category related client API's to retrofit.
These 3 were merged into searchCategories as they were duplicates.
I'll have these ready tomorrow, but they are independent of searchCategories.
By the way, should I delete the mwApi originals?