OkHttpJsonApi#getMediaList migrated to retrofit #3054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@ilgazer you can click here to see the review status or cancel the code review job.
Codecov Report
@@ Coverage Diff @@
## backend-overhaul #3054 +/- ##
===================================================
+ Coverage 4.71% 4.94% +0.23%
===================================================
Files 261 260 -1
Lines 12195 12153 -42
Branches 1043 1038 -5
===================================================
+ Hits 575 601 +26
+ Misses 11581 11507 -74
- Partials 39 45 +6
Continue to review full report at Codecov.
|
maskaravivek
reviewed
Jul 6, 2019
| @@ -25,6 +25,6 @@ public CategoryImageController(OkHttpJsonApiClient okHttpJsonApiClient) { | |||
| * @return | |||
| */ | |||
| public Single<List<Media>> getCategoryImages(String categoryName) { | |||
| return okHttpJsonApiClient.getMediaList("category", categoryName); | |||
| return null;// okHttpJsonApiClient.getMediaList("category", categoryName); | |||
There was a problem hiding this comment.
@ilgazer Can you update this. :)
|
That class is no longer used and will be deleted. Thanks for catching that.
6 Temmuz 2019 Cumartesi tarihinde Vivek Maskara <notifications@github.com>
yazdı:
… ***@***.**** commented on this pull request.
The PR looks great. Thanks for helping us with the migration. :)
------------------------------
In app/src/main/java/fr/free/nrw/commons/category/
CategoryImageController.java
<#3054 (comment)>
:
> @@ -25,6 +25,6 @@ public CategoryImageController(OkHttpJsonApiClient okHttpJsonApiClient) {
* @return
*/
public Single<List<Media>> getCategoryImages(String categoryName) {
- return okHttpJsonApiClient.getMediaList("category", categoryName);
+ return null;// okHttpJsonApiClient.getMediaList("category", categoryName);
@ilgazer <https://github.com/ilgazer> Can you update this. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3054?email_source=notifications&email_token=AB2EXIYOTIFEXHJSLEZKBPLP6AX73A5CNFSM4H6NLV3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5UZRQY#pullrequestreview-258578627>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB2EXI7AUHSMKCLOYUHTVNTP6AX73ANCNFSM4H6NLV3A>
.
|
maskaravivek
approved these changes
Jul 6, 2019
There was a problem hiding this comment.
Works perfectly for me. There's just 1 issue.
- search for something for eg, "mango"
- search the categories tab
- select a category from this tab
- media is not found.
The issue is that the category passed is not suffixed with "Category:".
But i believe the issue is not related to this PR. So we can fix it separately.
maskaravivek
pushed a commit
to maskaravivek/apps-android-commons
that referenced
this pull request
Jul 6, 2019
* Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController
Maybe we should set a standart on whether we should pass around page names with namespace or not throughout the app. |
maskaravivek
pushed a commit
to maskaravivek/apps-android-commons
that referenced
this pull request
Jul 7, 2019
* Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController
maskaravivek
pushed a commit
to maskaravivek/apps-android-commons
that referenced
this pull request
Jul 7, 2019
* Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController
maskaravivek
pushed a commit
to maskaravivek/apps-android-commons
that referenced
this pull request
Jul 10, 2019
* Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController
maskaravivek
pushed a commit
that referenced
this pull request
Jul 15, 2019
…Client (#3056) * With media client APIs migrated to retrofit (#2998) * With media client APIs migrated to retrofit * Add test cases and java docs * Fix test * Fix build * Fix build and other minor issues * Fix tests * Categories related client API's migrated to retrofit (#3053) * Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical * With media client APIs migrated to retrofit (#2998) * With media client APIs migrated to retrofit * Add test cases and java docs * Fix test * Fix build * Fix build and other minor issues * Fix tests * Categories related client API's migrated to retrofit (#3053) * Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical * OkHttpJsonApi#getMediaList migrated to retrofit (#3054) * Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController * getSubCategoryList and getParentCategoryList migrated to retrofit (#3055) * Migrated getSubCategoryList to retrofit * Migrated getParentCategoryList to retrofit * Removed obsolete functions * Added tests * Fixed small bugs * Migrated OkHttpJsonApiClient#getMedia and getPictureOfTheDay to MediaClient * Removed obsolete functions and added tests * Fixed merge errors * With media client APIs migrated to retrofit (#2998) * With media client APIs migrated to retrofit * Add test cases and java docs * Fix test * Fix build * Fix build and other minor issues * Fix tests * Categories related client API's migrated to retrofit (#3053) * Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical * OkHttpJsonApi#getMediaList migrated to retrofit (#3054) * Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController * getSubCategoryList and getParentCategoryList migrated to retrofit (#3055) * Migrated getSubCategoryList to retrofit * Migrated getParentCategoryList to retrofit * Removed obsolete functions * Added tests * Fixed small bugs * Consume login client from data client library (#2894) Fix actions for review client Use data client library for notifications With delete helper migrated to data client With wikidata edits With notifications and modifications migrated to data client With upload migrated to retrofit Delete unused code Reuse thank interface from the library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates OkHttpJsonApi#getMediaList to 2 different functions, MediaClient#getMediaListFromSearch and MEdiaClient#getMediaListFromCategory.