Migrated OkHttpJsonApiClient#getMedia and getPictureOfTheDay to MediaClient #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* With media client APIs migrated to retrofit * Add test cases and java docs * Fix test * Fix build * Fix build and other minor issues * Fix tests
* Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical
* With media client APIs migrated to retrofit * Add test cases and java docs * Fix test * Fix build * Fix build and other minor issues * Fix tests
* Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical
* Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController
…mmons-app#3055) * Migrated getSubCategoryList to retrofit * Migrated getParentCategoryList to retrofit * Removed obsolete functions * Added tests * Fixed small bugs
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@ilgazer you can click here to see the review status or cancel the code review job.
…overhaul-retrofit-getMedia # Conflicts: # app/src/main/java/fr/free/nrw/commons/category/CategoryClient.java # app/src/main/java/fr/free/nrw/commons/category/CategoryInterface.java # app/src/main/java/fr/free/nrw/commons/media/MediaClient.java # app/src/main/java/fr/free/nrw/commons/media/MediaInterface.java # app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java # app/src/main/java/fr/free/nrw/commons/mwapi/MediaWikiApi.java # app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java # app/src/main/java/fr/free/nrw/commons/review/ReviewHelper.java # app/src/test/kotlin/fr/free/nrw/commons/category/CategoryClientTest.kt # app/src/test/kotlin/fr/free/nrw/commons/media/MediaClientTest.kt # app/src/test/kotlin/fr/free/nrw/commons/mwapi/OkHttpJsonApiClientTest.kt # app/src/test/kotlin/fr/free/nrw/commons/review/ReviewHelperTest.kt
Contributor
|
@ilgazer Can you check why travis build is failing. :) |
* With media client APIs migrated to retrofit * Add test cases and java docs * Fix test * Fix build * Fix build and other minor issues * Fix tests
* Commit 1 * searchCategories migrated to retrofit * SearchCategoriesFragment migrated to new API * Removed unused code * Created tests * implemented searching by prefix fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones. * added tests * Migrated searchTitles to searchCategories, function behaviour seems identical
* Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages * Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages * Removed unused code and tests * Fixed small bug * Added tests * Removed unused CategoryImageController
…mmons-app#3055) * Migrated getSubCategoryList to retrofit * Migrated getParentCategoryList to retrofit * Removed obsolete functions * Added tests * Fixed small bugs
Fix actions for review client Use data client library for notifications With delete helper migrated to data client With wikidata edits With notifications and modifications migrated to data client With upload migrated to retrofit Delete unused code Reuse thank interface from the library
6d88b6a to
1faad66
Compare
There was a problem hiding this comment.
PullRequest network review has been cancelled
You can reactivate the code review job from the PullRequest dashboard - or - by adding [pr] to the title of this code review.
6c94a5a to
853c8a6
Compare
Contributor
|
@ilgazer Can you take a look at the merge conflicts? :) |
Contributor
Author
|
Is there more? Oh no :D By the way, I'm on holiday and Android Studio is
refusing to work on my laptop, so it might be a while before I get to that
:|
…On Jul 10, 2019 8:43 PM, "Vivek Maskara" ***@***.***> wrote:
@ilgazer <https://github.com/ilgazer> Can you take a look at the merge
conflicts? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3056?email_source=notifications&email_token=AB2EXI3X52ITRKXV3ZUVGHDP6YNTPA5CNFSM4H6TTHIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZUGZ4Q#issuecomment-510160114>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB2EXI5AUTRODVE6X7BCX63P6YNTPANCNFSM4H6TTHIA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.