Fix #2874 shouldn't use the words "success" and "failure" #4000

isdl03 · 2020-10-28T19:58:04Z

Description (required)

Fixes #2874

What changes did you make and why?
Replaced the following three strings :
1)Login success!
You are logged in!

Wallpaper set successfully!
Wallpaper set!

Sending Thanks: Success
Thanks Sent!

Tests performed (required)

Tested on Pixel 3 with API level 28.

Need help? See https://support.google.com/android/answer/9075928

codecov-io · 2020-10-28T21:33:30Z

Codecov Report

Merging #4000 (cc71341) into master (8e9b39f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4000   +/-   ##
=========================================
  Coverage     10.58%   10.58%           
  Complexity      476      476           
=========================================
  Files           343      343           
  Lines         12906    12906           
  Branches       1008     1008           
=========================================
  Hits           1366     1366           
  Misses        11472    11472           
  Partials         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e9b39f...cc71341. Read the comment docs.

sivaraam

Thanks for the PR! I've left one inline comment. Also, to completely address #2874 we would've to replace all instances of the usage mentioned there. It looks like there are still some strings left even after this change. A few instances are,

apps-android-commons/app/src/main/res/values/strings.xml

Line 514 in 44bf604

    
           <string name="send_thank_success_message">Successfully sent thanks to %1$s</string>

apps-android-commons/app/src/main/res/values/strings.xml

Line 516 in 44bf604

<string name="send_thank_failure_title">Sending Thanks: Failure</string>

apps-android-commons/app/src/main/res/values/strings.xml

Line 515 in 44bf604

<string name="send_thank_failure_message">Failed to send thanks %1$s</string>

So, it would be great if you could fix those too.

Also, make sure to properly update the "Fixes #INSERT_ISSUE_NUMBER_HERE" template in the PR description to mention #2874

sivaraam · 2020-10-31T17:42:43Z

app/src/main/res/values/strings.xml

@@ -50,7 +50,7 @@
  <string name="signup">Sign up</string>
  <string name="logging_in_title">Logging in</string>
  <string name="logging_in_message">Please wait…</string>
-  <string name="login_success">Login success!</string>
+  <string name="login_success">You are logged in!</string>


I believe "Logged in!" would be shorter and equally precise here.

arishtajain14 · 2021-01-09T09:36:21Z

@sivaraam We have made the changes as requested. Kindly review the same.

sivaraam · 2021-01-16T17:07:17Z

@sivaraam We have made the changes as requested. Kindly review the same.

Apologies for the delay. I was supposed to get around to this long ago but it slipped. Currently, I'm in lack of time due to a medical emergency in my family. I'll be sure to review when I find the time. We'll see if someone else could beat me to it, instead :)

neslihanturan

Hey @isdl03 , thanks for changes. I have added some minor suggestions. Please do not hesitate to say if you have doubts about my reviews, considering I am not a native speaker.

Also, plase fix conflicts.

neslihanturan · 2021-02-15T13:26:08Z

app/src/main/res/values/strings.xml

  <string name="upload_paused_notification_title">Uploading %1$s paused</string>
  <string name="upload_failed_notification_subtitle">Tap to view</string>
  <string name="upload_paused_notification_subtitle">Tap to view</string>
  <string name="title_activity_contributions">My Recent Uploads</string>
  <string name="contribution_state_queued">Queued</string>
-  <string name="contribution_state_failed">Failed</string>
+  <string name="contribution_state_failed">Error detected</string>


I think failed fits better for this specific usage. Error detected does not indicate that upload process failed, ie. we may have an error for adding categories (so error detected) and upload may be done. So, "error detected" is not necessarily mean "upload failed".

Suggestions are welcome, I am not the most native Ensglish speaker I know.

neslihanturan · 2021-02-15T13:27:12Z

app/src/main/res/values/strings.xml

  <string name="login_failed_blocked">Sorry, this user has been blocked on Commons</string>
  <string name="login_failed_2fa_needed">You must provide your two factor authentication code.</string>
-  <string name="login_failed_generic">Login failed</string>
+  <string name="login_failed_generic">Error logging in</string>


Is it legal to say "Error logging in" gramatically?

I'm not sure about whether it's legal or not (I'm not a native speaker, too 🙂). But I could certainly say that "Error logging in doesn't sound any better than "Login failed".

neslihanturan · 2021-02-15T13:39:06Z

app/src/main/res/values/strings.xml

  <string name="delete_helper_show_deletion_message_if">Nominated %1$s for deletion.</string>
-  <string name="delete_helper_show_deletion_title_failed">Failed</string>
+  <string name="delete_helper_show_deletion_title_failed">Title could not be deleted</string>


Please use "Cannot be deleted" or "Could not be deleted" instead. Do not include title here.

neslihanturan · 2021-02-23T12:37:02Z

Hey @isdl03 , how is the things going with this issue? Please do not hesitate to ask if you need further explanation. Currently minor reviews and conflict fixes should be done:)

isdl03 · 2021-02-23T13:53:41Z

Currently our midsem exams are going so we will try to resolve the issue after 25th February. Thanks

…

On Tue, Feb 23, 2021, 18:07 neslihanturan ***@***.***> wrote: Hey @isdl03 <https://github.com/isdl03> , how is the things going with this issue? Please do not hesitate to ask if you need further explanation. Currently minor reviews and conflict fixes should be done:) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4000 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARQR4OCFY7J6T5LLD2RQXXLTAOOP7ANCNFSM4TCZR7BA> .

nicolas-raoul · 2021-06-19T02:53:49Z

Would you mind solving the conflicts? :-)

isdl03 · 2021-06-19T18:03:08Z

@nicolas-raoul I have made the changes as requested. Kindly review the same.

nicolas-raoul · 2021-06-21T06:54:52Z

Oops, seems that there is already another conflict... sorry but would you mind solving again? Thanks!

nicolas-raoul · 2021-06-21T11:49:43Z

You can either rebase on master, or just pull from master. Please let me know when you are done :-)

isdl03 · 2021-06-21T12:16:45Z

@nicolas-raoul I have resolved the conflicts.

neslihanturan

Some irrelevant changes exists

neslihanturan · 2021-06-21T15:36:12Z

app/src/main/res/values/strings.xml

  <string name="login_failed_throttled">Too many unsuccessful attempts. Please try again in a few minutes.</string>
  <string name="login_failed_blocked">Sorry, this user has been blocked on Commons</string>
  <string name="login_failed_2fa_needed">You must provide your two factor authentication code.</string>
  <string name="login_failed_generic">Login failed</string>
  <string name="share_upload_button">Upload</string>
  <string name="multiple_share_base_title">Name this set</string>
-  <string name="add_set_name_toast">Please provide a name for this set</string>


Seems like some strings are removed in this PR and this is irrelevant with avoiding usage of "failure/success"

neslihanturan · 2021-08-06T10:18:55Z

hey @isdl03 , are you still interested?:)

arishtajain14 mentioned this pull request Oct 28, 2020

"check category failure title" and "check category success title" shouldn't use the words "success" and "failure" #2874

Open

Replaced three strings

e8a10b1

sivaraam requested changes Oct 31, 2020

View reviewed changes

isdl03 added 2 commits December 3, 2020 10:21

Update strings.xml

e660a99

Update strings.xml

d7760e1

sivaraam mentioned this pull request Dec 22, 2020

Erosa issue 2874 #3991

Closed

isdl03 added 3 commits January 9, 2021 01:00

Update strings.xml

7a56503

Update strings.xml

aeadda4

Merge branch 'master' into new_branch

cc71341

misaochan requested a review from sivaraam January 14, 2021 15:39

neslihanturan requested changes Feb 15, 2021

View reviewed changes

neslihanturan changed the title ~~Replaced three strings~~ Fix #2874 shouldn't use the words "success" and "failure" Feb 15, 2021

Update strings.xml

399474f

isdl03 added 9 commits June 21, 2021 16:16

Update strings.xml

985b422

Update strings.xml

f4bd638

Update strings.xml

a99832e

Update strings.xml

0c028d3

Update strings.xml

f6c5b9d

Update strings.xml

0327d47

Update strings.xml

3f6f6a9

Update strings.xml

0ad498a

Update strings.xml

4ce5c31

Update strings.xml

0a025ae

neslihanturan requested changes Jun 21, 2021

View reviewed changes

Update strings.xml

797808f

neslihanturan closed this Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #2874 shouldn't use the words "success" and "failure" #4000

Fix #2874 shouldn't use the words "success" and "failure" #4000

isdl03 commented Oct 28, 2020 •

edited by domdomegg

Loading

codecov-io commented Oct 28, 2020 •

edited

Loading

sivaraam left a comment •

edited

Loading

sivaraam Oct 31, 2020

arishtajain14 commented Jan 9, 2021

sivaraam commented Jan 16, 2021

neslihanturan left a comment

neslihanturan Feb 15, 2021

neslihanturan Feb 15, 2021

sivaraam Feb 16, 2021

neslihanturan Feb 15, 2021

neslihanturan commented Feb 23, 2021

isdl03 commented Feb 23, 2021 via email

nicolas-raoul commented Jun 19, 2021

isdl03 commented Jun 19, 2021

nicolas-raoul commented Jun 21, 2021

nicolas-raoul commented Jun 21, 2021

isdl03 commented Jun 21, 2021 •

edited

Loading

neslihanturan left a comment

neslihanturan Jun 21, 2021

neslihanturan commented Aug 6, 2021

Fix #2874 shouldn't use the words "success" and "failure" #4000

Fix #2874 shouldn't use the words "success" and "failure" #4000

Conversation

isdl03 commented Oct 28, 2020 • edited by domdomegg Loading

codecov-io commented Oct 28, 2020 • edited Loading

Codecov Report

sivaraam left a comment • edited Loading

Choose a reason for hiding this comment

sivaraam Oct 31, 2020

Choose a reason for hiding this comment

arishtajain14 commented Jan 9, 2021

sivaraam commented Jan 16, 2021

neslihanturan left a comment

Choose a reason for hiding this comment

neslihanturan Feb 15, 2021

Choose a reason for hiding this comment

neslihanturan Feb 15, 2021

Choose a reason for hiding this comment

sivaraam Feb 16, 2021

Choose a reason for hiding this comment

neslihanturan Feb 15, 2021

Choose a reason for hiding this comment

neslihanturan commented Feb 23, 2021

isdl03 commented Feb 23, 2021 via email

nicolas-raoul commented Jun 19, 2021

isdl03 commented Jun 19, 2021

nicolas-raoul commented Jun 21, 2021

nicolas-raoul commented Jun 21, 2021

isdl03 commented Jun 21, 2021 • edited Loading

neslihanturan left a comment

Choose a reason for hiding this comment

neslihanturan Jun 21, 2021

Choose a reason for hiding this comment

neslihanturan commented Aug 6, 2021

isdl03 commented Oct 28, 2020 •

edited by domdomegg

Loading

codecov-io commented Oct 28, 2020 •

edited

Loading

sivaraam left a comment •

edited

Loading

isdl03 commented Jun 21, 2021 •

edited

Loading