Some regressions in plugin

[le717]

I'm opening this not only for reporting, but also to document what I am seeing. I will update this until I've uncovered everything.

c911970 has broken a number of tests and thus functionality:

• Browser should be Safari on Mac
• Browser should be Safari on iPad
• Browser should be Safari on iPhone
• Browser name should be Android
• There are three more broken tests right now, but they are not directly related to this, and are out of scope for the issue at hand.

Through manual testing, I've found browser.safari is returning undefined, and browser.name is returning "version" with some UAs.

The script changes in that commit, however, were only applied to the script in the test/src folder. These issues do not reproduce with the script under dist/.

I am partly to blame here, as some of the changes made were mine (see the le717-safari-version branch and #35).

TODO

• Make browser.safari work again
• Research what UAs are breaking browser.name and fix that
• Ensure Wrong version number on Safari #35 is still fixed
• Code review (Fix regressions in plugin #49)

[jh9027]

This has also broken the minified version in the dist folder. The non-minified version is still working however.

[le717]

@gabceb @bhamodi I have finally got a fix for all this, with tests passing and confirming #35 is still fixed. I'll put up a PR just as soon as #48 is worked out (I want to base the changes on that, makes it a lot easier). 😅

[bhamodi]

Nice! 👍