Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
This was left over from when I added ChromeOS support. I did not know you already converted the UA to lowercase.
Contributor
|
LGTM. 🚢 |
test/test.js
Outdated
Contributor
There was a problem hiding this comment.
Nitpick, original spacing was correct here. 😝
Contributor
Author
There was a problem hiding this comment.
Tool error, will fix.
924a66c to
6a8a428
Compare
Contributor
Author
|
@gabceb Would you like take a look at this? |
Contributor
Author
|
I've run the tests against this multiple times and performed manual testing, and everything checks out. I broke the script, and I am going to fix it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #46. This is funny because the fix is identical to #44, but I closed that in order to fix this and said I would look at it later.
AppleWebKit/cc @gabceb @bhamodi