Correctly match Safari version#37
Correctly match Safari version#37le717 wants to merge 3 commits intogabceb:masterfrom le717:safari-version
Conversation
I thought for sure it was fixed in 1d235da
|
We are still not matching the Safari version correctly. I've pushed your commits and some changes to get testing running. Safari with user agent I'll add how to get testing work on #36 |
|
Your commits are pushed at https://github.com/gabceb/jquery-browser-plugin/tree/le717-safari-version |
|
Do I need to close this and base further changes on that branch and you can merge that branch instead? |
|
I just tested this, works like a charm, thanks! When will this be merged in? Time for a new release, perhaps? : ) |
|
Feel free to leave this here and pull down the branch I created. Once that branch is merged with master this PR will close |
|
@gabceb Well this is interesting. |
|
Oh hey, I just got this working correctly, with all tests passing. I'll submit a PR and get the conflict sorted out at the same time. :) |
|
Closing in favor of #44. |
@gabceb For #35. As I said in my last comment, the information required was already present, just not used. However, the fixes retains the desired action for all other browsers, thus not resulting in breaking changes as I first thought.
This is is best reviewed by using the https://github.com/gabceb/jquery-browser-plugin/pull/37/files?w=1 URL to strip white space changes. It seems 1d235da did not fully fix #26, though I thought for sure it did...