Skip to content

Correctly match Safari version#37

Closed
le717 wants to merge 3 commits intogabceb:masterfrom
le717:safari-version
Closed

Correctly match Safari version#37
le717 wants to merge 3 commits intogabceb:masterfrom
le717:safari-version

Conversation

@le717
Copy link
Contributor

@le717 le717 commented Sep 28, 2014

@gabceb For #35. As I said in my last comment, the information required was already present, just not used. However, the fixes retains the desired action for all other browsers, thus not resulting in breaking changes as I first thought.

This is is best reviewed by using the https://github.com/gabceb/jquery-browser-plugin/pull/37/files?w=1 URL to strip white space changes. It seems 1d235da did not fully fix #26, though I thought for sure it did...

@gabceb
Copy link
Owner

gabceb commented Sep 29, 2014

We are still not matching the Safari version correctly. I've pushed your commits and some changes to get testing running. Safari with user agent Mozilla/5.0 (iPad; CPU OS 7_0 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53 should return 637.51.1 but we are matching 9537.53 instead.

I'll add how to get testing work on #36

@gabceb
Copy link
Owner

gabceb commented Sep 29, 2014

@le717
Copy link
Contributor Author

le717 commented Sep 29, 2014

Do I need to close this and base further changes on that branch and you can merge that branch instead?

@lehni
Copy link

lehni commented Sep 29, 2014

I just tested this, works like a charm, thanks! When will this be merged in? Time for a new release, perhaps? : )

@le717
Copy link
Contributor Author

le717 commented Sep 29, 2014

@lehni Looks like there is another issue @gabceb wants me to look at before a new release is pushed. Until then, you might want to pull in that file and leave a TODO to check back for a proper release soon.

@gabceb
Copy link
Owner

gabceb commented Sep 29, 2014

Feel free to leave this here and pull down the branch I created. Once that branch is merged with master this PR will close

@le717
Copy link
Contributor Author

le717 commented Oct 27, 2014

@gabceb Well this is interesting.
Some of the changes you (and/or I, don't recall which one) made to partially fix this only made it's way into the test/src copy and not the main dist copy, meaning #43 will create a conflict between the two versions. It might be best to get those changes resolved then get #43 merged, as it might be easier to sort out what was changed.

@le717
Copy link
Contributor Author

le717 commented Oct 27, 2014

Oh hey, I just got this working correctly, with all tests passing. I'll submit a PR and get the conflict sorted out at the same time. :)

@le717 le717 mentioned this pull request Oct 27, 2014
@le717
Copy link
Contributor Author

le717 commented Oct 27, 2014

Closing in favor of #44.

@le717 le717 closed this Oct 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistent code indentation

3 participants