Skip to content

Safari version + more#44

Closed
le717 wants to merge 1 commit intogabceb:masterfrom
le717:finish-safari-version
Closed

Safari version + more#44
le717 wants to merge 1 commit intogabceb:masterfrom
le717:finish-safari-version

Conversation

@le717
Copy link
Contributor

@le717 le717 commented Oct 27, 2014

Should finally finish #35, replaces #37.

Three things:
f0f22a4 
* Finish correctly matching Safari version and versionNumber, all tests
passing
* var errors in test/test.js
* Add .editorconfig (EditorConfig.org) to help maintain a consistent
formatting
This was referenced Oct 27, 2014
Closed
Closed
@le717
Copy link
Contributor Author

le717 commented Oct 28, 2014

@gabceb Since there will be conflicts between this and #43, merge that one first. I can merge with those changes afterward (I initially made this based on that patch).

@le717 le717 closed this Nov 12, 2014
@le717
Copy link
Contributor Author

le717 commented Nov 12, 2014

Closing this for now, will revise after regressions are resolved.

@le717 le717 mentioned this pull request Nov 18, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@le717