This repository was archived by the owner on Oct 8, 2021. It is now read-only.
animationComplete: Refer to the default duration using array notation#7118
Closed
gabrielschulhof wants to merge 1 commit intomasterfrom
Closed
animationComplete: Refer to the default duration using array notation#7118gabrielschulhof wants to merge 1 commit intomasterfrom
gabrielschulhof wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
@gabrielschulhof i think i would prefer to change the name as suggested in the original issue rather then use array notation otherwise we will need to document that this and only this prop can only be set / accessed via array notation because of the reserved keyword. I had already fixed this along with 7114 while on the plane on the way home but didn't have good wifi #7119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-7116