This repository was archived by the owner on Oct 8, 2021. It is now read-only.
AnimationComplete: change default to durationDefault fix duration read#7119
Closed
AnimationComplete: change default to durationDefault fix duration read#7119
Conversation
There was a problem hiding this comment.
... maybe add || isNaN( duration ) anyway, in case the duration-as-a-string was defined, but contained garbage ... ?
Contributor
Author
There was a problem hiding this comment.
i suppose an extra safeguard cant hurt
There was a problem hiding this comment.
Actually, if you add this condition, you don't really need to check if duration is undefined before passing it into parseFloat(), because
parseFloat( undefined ) => NaN
parseFloat( "" ) => NaN
This was referenced Feb 18, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safegurard against NAN values and fix camelcase of duration name
Fixes gh-7114
Fixes gh-7118