Calendar WIP #1281
Closed
Calendar WIP #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change status caching, fix existing value related methods, introduce $.date construction with date object, add selected getter
Add calendar widget by copying and renaming datepicker widget files
Add a basic _isValid method for both widgets to check for valid dates.
The method should return the actual date object instead of the copied $.date object
Add min and max option by extending _isValid method and improving render day cell mechanism
Simplify calendar generation, use CSS instead of inline styles, fix destroy method
Simplify calendar generation, remove unneeded inline styles
Fix unit tests after changing HTML structure, remove unneeded tests, adjust CSS selectors to match new widget structure
Remove shortcut for closing the calendar and erasing the date (CTRL+END)
Use HTML5 date format for reading min and max attributes from input element. Remove now unneeded helper method for parsing date strings.
Remove duplicated core unit tests from datepicker tests.
Closed
|
Hey @scottgonzalez and @jzaefferer, please check out: #1316 |
|
Sorry, linked the wrong name. @scottgonzalez did you notice the new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #1260, but was itself replaced by #1316.
I rebased and cleaned up the history for the datepicker branch and then did the same for #1260. However, I was only able to do minor cleanup in this branch because the first commit causes several test failures and I wanted to be able to comment on stuff before I started making major changes to the history. Especially since it's not as easy to clean up as the datepicker branch.